Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add support for switchport port-security. #3561

Merged
merged 12 commits into from Mar 25, 2024
Merged

Feat(eos_cli_config_gen): Add support for switchport port-security. #3561

merged 12 commits into from Mar 25, 2024

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Jan 29, 2024 •
edited

Change Summary

Add support for switchport port-security feature in global and switched ethernet interface configuration.

Related Issue(s)

Fixes #2544

Component(s) name

arista.avd.eos_cli_config_gen

How to test

switchport port-security
switchport port-security violation protect log
switchport port-security mac-address maximum 100

interface ethernet1
      switchport port-security
      switchport port-security violation protect log
      switchport port-security mac-address maximum 100
interface ethernet2
      switchport port-security
      no switchport port-security mac-address maximum disabled
      switchport port-security vlan 1 mac-address maximum 3
      switchport port-security vlan 2 mac-address maximum 3
      switchport port-security vlan 3 mac-address maximum 3
      switchport port-security vlan default mac-address maximum 2

Checklist

User Checklist

  • Check the config ordering on EOS device

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Shivani-gslab Shivani-gslab requested review from a team as code owners January 29, 2024 13:13
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Jan 29, 2024
@Shivani-gslab Shivani-gslab marked this pull request as draft January 29, 2024 13:18
ClausHolbechArista
ClausHolbechArista reviewed Jan 29, 2024
View reviewed changes
...ions/arista/avd/roles/eos_cli_config_gen/templates/documentation/switchport-port-security.j2 Outdated Show resolved Hide resolved
...ions/arista/avd/roles/eos_cli_config_gen/templates/documentation/switchport-port-security.j2 Outdated Show resolved Hide resolved
...ions/arista/avd/roles/eos_cli_config_gen/templates/documentation/switchport-port-security.j2 Outdated Show resolved Hide resolved
...ions/arista/avd/roles/eos_cli_config_gen/templates/documentation/switchport-port-security.j2 Outdated Show resolved Hide resolved
...ions/arista/avd/roles/eos_cli_config_gen/templates/documentation/switchport-port-security.j2 Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/ethernet-interfaces.j2 Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/ethernet-interfaces.j2 Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/ethernet-interfaces.j2 Outdated Show resolved Hide resolved
@github-actions github-actions bot added the state: conflict PR with conflict label Jan 29, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Jan 30, 2024
@Shivani-gslab Shivani-gslab marked this pull request as ready for review January 30, 2024 12:00
@Shivani-gslab Shivani-gslab marked this pull request as draft January 31, 2024 05:45
@Shivani-gslab Shivani-gslab marked this pull request as ready for review January 31, 2024 09:30
@github-actions github-actions bot added the state: conflict PR with conflict label Feb 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added the state: conflict PR with conflict label Feb 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 13, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@sugetha24 sugetha24 self-requested a review February 27, 2024 00:44
sugetha24
sugetha24 approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@sugetha24 sugetha24 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Molecule test passed. Artifacts checked

@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Feb 27, 2024
@ClausHolbechArista ClausHolbechArista requested a review from a team February 27, 2024 07:13
JulioPDX
JulioPDX approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@JulioPDX JulioPDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the PR

@JulioPDX JulioPDX merged commit 01d1336 into aristanetworks:devel Mar 25, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sugetha24 sugetha24 sugetha24 approved these changes

@JulioPDX JulioPDX JulioPDX approved these changes

@alexeygorbunov alexeygorbunov Awaiting requested review from alexeygorbunov

@ClausHolbechArista ClausHolbechArista Awaiting requested review from ClausHolbechArista

Assignees

@Shivani-gslab Shivani-gslab

Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): Add support for switchport port-security
4 participants
@Shivani-gslab @sugetha24 @JulioPDX @ClausHolbechArista