Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): add router IGMP host proxy configuration support #3565

Merged
merged 22 commits into from Feb 8, 2024
Merged

Feat(eos_cli_config_gen): add router IGMP host proxy configuration support #3565

merged 22 commits into from Feb 8, 2024

Conversation

philippebureau
Copy link
Contributor

@philippebureau philippebureau commented Jan 30, 2024 •
edited by carlbuchmann

Change Summary

Add host proxy support under router IGMP

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

proposed data model

router_igmp:
  host_proxy_match_mroute:
  vrf:
     - name: PROD
       host_proxy_match_mroute: all
    - name: BLUE
       host_proxy_match_mroute: iif

How to test

see the molecule test included

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@philippebureau philippebureau requested review from a team as code owners January 30, 2024 20:02
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Jan 30, 2024
@philippebureau philippebureau changed the title Feat(eos_cli_config_gen) add router IGMP host proxy configuration support Feat(eos_cli_config_gen): add router IGMP host proxy configuration support Jan 30, 2024
@Shivani-gslab
Copy link
Contributor

For me this is unrecognised command-

s1-leaf1(config-router-igmp)#host-proxy ?
% Unrecognized command

s1-leaf1(config-router-igmp)#host-proxy match mroute all
% Invalid input

@philippebureau
Copy link
Contributor Author

For me this is unrecognised command-

s1-leaf1(config-router-igmp)#host-proxy ?
% Unrecognized command

s1-leaf1(config-router-igmp)#host-proxy match mroute all
% Invalid input

what version of EOS are you running?

@github-actions github-actions bot added the state: conflict PR with conflict label Feb 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Shivani-gslab
Copy link
Contributor

For me this is unrecognised command-

s1-leaf1(config-router-igmp)#host-proxy ?
% Unrecognized command

s1-leaf1(config-router-igmp)#host-proxy match mroute all
% Invalid input

what version of EOS are you running?

its 4.30.2F-33092737.4302F

@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added the state: conflict PR with conflict label Feb 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

ClausHolbechArista
ClausHolbechArista reviewed Feb 2, 2024
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eos_cli_config_gen should not have "clever" logic, so if someone adds vrf default, EOS will just move it back to the global context.

ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-igmp.j2 Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added the state: conflict PR with conflict label Feb 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

philippebureau and others added 22 commits February 8, 2024 10:54
@philippebureau @sugetha24
CI(molecule): Update Molecule artifacts
ab01f01
@philippebureau @sugetha24
rebase
331a274
@philippebureau @sugetha24
molecule run
02c1d8e
@philippebureau @sugetha24
documentation lint fix
23878e6
@philippebureau @carlbuchmann @sugetha24
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/schema…
1bef4c2 
…s/schema_fragments/router_igmp.schema.yml

Co-authored-by: Carl Buchmann <carl.buchmann@arista.com>
@philippebureau @sugetha24
vrf -> vrfs
1f955d2
@philippebureau @sugetha24
documentation table update
8963feb
@philippebureau @sugetha24
reajust schema and add if defined checks
aff76da
@philippebureau @sugetha24
documentation link fix
a3921fb
@philippebureau @ClausHolbechArista @sugetha24
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/templa…
cc499aa 
…tes/documentation/router-igmp.j2

Co-authored-by: Claus Holbech <holbech@arista.com>
@philippebureau @ClausHolbechArista @sugetha24
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/templa…
160e696 
…tes/documentation/router-igmp.j2

Co-authored-by: Claus Holbech <holbech@arista.com>
@philippebureau @ClausHolbechArista @sugetha24
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/templa…
fd3782c 
…tes/documentation/router-igmp.j2

Co-authored-by: Claus Holbech <holbech@arista.com>
@philippebureau @sugetha24
remove extra if loops in doc template
564fa82
@philippebureau @sugetha24
reajust schema and add if defined checks
5b92400
@philippebureau @sugetha24
pre-commit run
1dd4928
@philippebureau @sugetha24
move the vrf creation above match_route if loop
d3874a2
@philippebureau @sugetha24
restore default vrf check
57dcc8e
@philippebureau @ClausHolbechArista @sugetha24
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/templa…
7e6a733 
…tes/eos/router-igmp.j2

Co-authored-by: Claus Holbech <holbech@arista.com>
@philippebureau @ClausHolbechArista @sugetha24
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/schema…
892742c 
…s/schema_fragments/router_igmp.schema.yml

Co-authored-by: Claus Holbech <holbech@arista.com>
@philippebureau @carlbuchmann @sugetha24
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/schema…
ec6902e 
…s/schema_fragments/router_igmp.schema.yml

Co-authored-by: Carl Buchmann <carl.buchmann@arista.com>
@philippebureau @carlbuchmann @sugetha24
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/schema…
cc9402f 
…s/schema_fragments/router_igmp.schema.yml

Co-authored-by: Carl Buchmann <carl.buchmann@arista.com>
@pre-commit-ci-lite @sugetha24
[pre-commit.ci lite] apply automatic fixes
1f11825
carlbuchmann
carlbuchmann approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 456bfff into aristanetworks:devel Feb 8, 2024
41 checks passed
@philippebureau philippebureau deleted the igmp-host-proxy branch February 9, 2024 18:13
@ClausHolbechArista ClausHolbechArista mentioned this pull request Feb 16, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@philippebureau philippebureau

Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@philippebureau @Shivani-gslab @carlbuchmann @ClausHolbechArista