Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_validate_state): ANTA Add a knob to exclude interfaces from being validated #3576

Merged
merged 16 commits into from
Feb 9, 2024
Merged

Feat(eos_validate_state): ANTA Add a knob to exclude interfaces from being validated #3576

merged 16 commits into from
Feb 9, 2024

Conversation

carl-baillargeon
Copy link
Contributor

Change Summary

Add a knob to the structured_config to disable Ethernet and Port-Channel interfaces validation.

Related Issue(s)

Fixes #3113

Component(s) name

arista.avd.eos_validate_state ANTA

Proposed changes

If validate_state is False under the endpoint connectivity models, the key will be inserted in the structured_config of the related interfaces so that the AvdTestInterfacesState test can catch it and skip.

If the key is not present, it defaults to True from AvdTestInterfacesState's point of view.

port_profiles:
  - profile: <name>
    validate_state: false
 
network_ports:
  - ...
    validate_state: false

servers:
  - name: <name>
    adapters:
      - ...
        validate_state: false

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@carl-baillargeon carl-baillargeon requested review from a team as code owners February 1, 2024 04:01
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_validate_state state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Feb 1, 2024
@github-actions github-actions bot added the state: conflict PR with conflict label Feb 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added the state: conflict PR with conflict label Feb 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

MaheshGSLAB
MaheshGSLAB approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Feb 6, 2024
gmuloc
gmuloc reviewed Feb 8, 2024
View reviewed changes
...tions/arista/avd/roles/eos_designs/python_modules/connected_endpoints/ethernet_interfaces.py Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_designs/docs/tables/port-profiles.md Outdated Show resolved Hide resolved
...ble_collections/arista/avd/roles/eos_cli_config_gen/schemas/eos_cli_config_gen.schema.pickle Outdated Show resolved Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/eos_validate_state_utils/avdtestbase.py Outdated Show resolved Hide resolved
...lections/arista/avd/molecule/eos_validate_state/inventory/group_vars/CONNECTED_ENDPOINTS.yml Outdated Show resolved Hide resolved
...lections/arista/avd/molecule/eos_validate_state/inventory/group_vars/CONNECTED_ENDPOINTS.yml Outdated Show resolved Hide resolved
...ollections/arista/avd/molecule/eos_validate_state/intended/structured_configs/dc1-leaf1a.yml Show resolved Hide resolved
@gmuloc gmuloc requested a review from a team February 8, 2024 22:21
carl-baillargeon and others added 4 commits February 8, 2024 18:23
@carl-baillargeon @gmuloc
Update ansible_collections/arista/avd/plugins/plugin_utils/eos_valida…
130c90e 
…te_state_utils/avdtestbase.py

Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
@carl-baillargeon @gmuloc
Update ansible_collections/arista/avd/molecule/eos_validate_state/inv…
f50942f 
…entory/group_vars/CONNECTED_ENDPOINTS.yml

Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
@carl-baillargeon @gmuloc
Update ansible_collections/arista/avd/molecule/eos_validate_state/inv…
22cd287 
…entory/group_vars/CONNECTED_ENDPOINTS.yml

Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
@carl-baillargeon @gmuloc
Update ansible_collections/arista/avd/roles/eos_designs/docs/tables/p…
a38afc4 
…ort-profiles.md

Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
@github-actions github-actions bot added the type: code quality CI and development toolset label Feb 8, 2024
@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the type: code quality CI and development toolset label Feb 9, 2024
@gmuloc gmuloc merged commit 0473e8c into aristanetworks:devel Feb 9, 2024
41 checks passed
@carl-baillargeon carl-baillargeon deleted the feat/validate_knob branch May 18, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@MaheshGSLAB MaheshGSLAB MaheshGSLAB approved these changes

@ClausHolbechArista ClausHolbechArista Awaiting requested review from ClausHolbechArista

Assignees

@carl-baillargeon carl-baillargeon

Labels
EPIC - eos_validate_state ANTA rn: Feat(eos_validate_state) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role role: eos_validate_state state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exclude interfaces from eos_validate_state report
3 participants
@carl-baillargeon @gmuloc @MaheshGSLAB