Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Add support for channel_id in l3_edge #3585

Merged
merged 10 commits into from
Feb 15, 2024
Merged

Feat(eos_designs): Add support for channel_id in l3_edge #3585

merged 10 commits into from
Feb 15, 2024

Conversation

chetryan
Copy link
Contributor

@chetryan chetryan commented Feb 3, 2024

Change Summary

Add support for channel_id on p2p_links port-channels.

This is required for use chases where the port-channel ID needs to follow other notation/number then being based on the Interface number of member interfaces.
This field is optional, and existing default behaviour remains in place.

Related Issue(s)

Fixes #3416

Component(s) name

arista.avd.eos_designs

Proposed changes

core_interfaces:
  p2p_links:
    - nodes: [ SITE2-LSR2, SITE2-LER1 ]
      id: 2
      port_channel:
        mode: active
        nodes_child_interfaces:
          - node: SITE2-LSR2
            interfaces: [ Ethernet14, Ethernet15 ]
            channel_id: 110.    # new field
          - node: SITE2-LER1
            interfaces: [ Ethernet13, Ethernet14 ]
            channel_id: 220    # new field

How to test

  • molecule test -s eos_designs-mpls-isis-sr-ldp

Checklist

User Checklist

  • Review the model updates and descriptions
  • Review the changes to the python utils code and verify logic

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@chetryan chetryan requested review from a team as code owners February 3, 2024 14:20
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Feb 3, 2024
@chetryan chetryan changed the title FEAT(eos_designs): Add support for channel_id in l3_edge Feat(eos_designs): Add support for channel_id in l3_edge Feb 3, 2024
@chetryan chetryan added this to In progress in US-PROJECT-02 via automation Feb 5, 2024
@github-actions github-actions bot added the state: conflict PR with conflict label Feb 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@chetryan chetryan force-pushed the 3416-feateos_designs-support-defining-the-port-channel-ip-for-p2p-port-channels branch from 36437d9 to 412edd1 Compare February 7, 2024 18:15
@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@chetryan chetryan force-pushed the 3416-feateos_designs-support-defining-the-port-channel-ip-for-p2p-port-channels branch from 3a45aa0 to b12c4fa Compare February 7, 2024 20:03
@github-actions github-actions bot added the state: conflict PR with conflict label Feb 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

ClausHolbechArista
ClausHolbechArista approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ClausHolbechArista ClausHolbechArista requested a review from a team February 12, 2024 19:29
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Feb 12, 2024
@ClausHolbechArista ClausHolbechArista requested a review from a team February 13, 2024 10:07
@dlobato
Copy link
Contributor

dlobato commented Feb 15, 2024

LGTM

hubert-arista
hubert-arista approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@hubert-arista hubert-arista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ClausHolbechArista ClausHolbechArista merged commit 27e605c into aristanetworks:devel Feb 15, 2024
38 checks passed
US-PROJECT-02 automation moved this from In progress to Done Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlobato dlobato dlobato approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@hubert-arista hubert-arista hubert-arista approved these changes

Assignees

@chetryan chetryan

Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
US-PROJECT-02
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat(eos_designs): support defining the port channel ip for P2P port-channels
4 participants
@chetryan @dlobato @ClausHolbechArista @hubert-arista