Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Uplink type 'lan' for WAN routers #3593

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Feb 5, 2024

Change Summary

Uplink type 'lan' for WAN routers

Component(s) name

arista.avd.eos_designs

Proposed changes

        # `uplink_type` must be `p2p`, `p2p-vrfs` or `lan` if `vtep` or `underlay_router` is true.
        #
        # For `p2p-vrfs`, the uplinks are configured as L3 interfaces with a subinterface for each VRF
        # in `network_services` present on both the uplink and the downlink switch.
        # The subinterface ID is the `vrf_id`.
        # 'underlay_router' and 'network_services.l3' must be set to true.
        # VRF `default` is always configured on the physical interface using the underlay routing protocol.
        # All subinterfaces use the same IP address as the physical interface.
        # Multicast is not supported.
        # Only BGP is supported for subinterfaces.
        #
        # For `lan`, a single uplink interface is supported and will be configured as an L3 Interface with
        # subinterfaces for each SVI defined under the VRFs in `network_services` as long as the uplink switch also
        # has the VLAN permitted by tag/tenant filtering.
        uplink_type: <str; "p2p" | "port-channel" | "p2p-vrfs" | "lan"; default="p2p">

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Feb 5, 2024
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos designs): Uplink type 'lan' for WAN routers Feat(eos_designs): Uplink type 'lan' for WAN routers Feb 5, 2024
@github-actions github-actions bot added the state: conflict PR with conflict label Feb 6, 2024
Copy link

github-actions bot commented Feb 6, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ClausHolbechArista ClausHolbechArista force-pushed the feat/eos_designs/uplink-type-lan-for-wan-routers branch from 088fc23 to 3442fd4 Compare February 7, 2024 12:51
@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 7, 2024
Copy link

github-actions bot commented Feb 7, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review February 27, 2024 07:46
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Feb 28, 2024
@gmuloc gmuloc requested a review from a team February 28, 2024 11:28
@ClausHolbechArista ClausHolbechArista merged commit bde6c1b into aristanetworks:devel Feb 28, 2024
38 checks passed
sugetha24 pushed a commit to sugetha24/ansible-avd that referenced this pull request Feb 28, 2024
…3593)

Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
gmuloc added a commit to gmuloc/avd that referenced this pull request Mar 11, 2024
…3593)

Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants