Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Implement WAN/LAN redistribution for eBGP LAN #3602

Merged

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Feb 8, 2024

Change Summary

  • aligned node types underlay protocols in node_type_keys and underlay_routing_protocol
  • changed default underlay_routing_protocol of wan_xx router
  • updated
  • Added FLOW tracking on uplinks for cv-pathfinder
  • Removed IPSec IKE profile to be generated for dataplane profile (will need to add it back in HA case, or rather, whenever there is a static peer configured in WAN case to be more generic in the mechanism)

Component(s) name

arista.avd.eos_designs

Proposed changes

NOTE: The behavior below is for WAN router

  • Mark all locally learned route on the router with the SoO extended community
  • Configure BGP route-map out towards underlay peers (LAN side) to advertise SoO marked routes (learned locally) and WAN routes (using AS-PATH)
  • Configure BGP route-map in from underlay peers (LAN side) to deny WAN routes (potentially learned from another router connected on the WAN) and to mark the prefixes received from the LAN with the SoO
  • configured the route-map conn-2-bgp to set the SoO on redistributed routes
  • Changed the EVPN-EXPORT-VRF-DEFAULT route-map to match on the SoO to decide what to send over EVPN in VRF default

How to test

molecule

Checklist

User Checklist

  • Also support AutoVPN edges
  • Test in a small lab setup to verify redistribution
  • Update documentation

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners February 8, 2024 08:57
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Feb 8, 2024
@gmuloc gmuloc force-pushed the wan-bgp-lan-route-map-policies branch from 2603fb2 to dc64643 Compare February 8, 2024 10:14
@gmuloc gmuloc force-pushed the wan-bgp-lan-route-map-policies branch from 6d5c48d to d026823 Compare February 8, 2024 21:57
@github-actions github-actions bot added the role: eos_cli_config_gen issue related to eos_cli_config_gen role label Feb 8, 2024
@gmuloc gmuloc requested review from ClausHolbechArista and a team February 9, 2024 14:05
@github-actions github-actions bot removed the role: eos_cli_config_gen issue related to eos_cli_config_gen role label Feb 9, 2024
Copy link

github-actions bot commented Feb 9, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Feb 9, 2024
@gmuloc gmuloc force-pushed the wan-bgp-lan-route-map-policies branch from 8bc3b37 to 07ee370 Compare February 9, 2024 17:01
@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 9, 2024
Copy link

github-actions bot commented Feb 9, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added the state: conflict PR with conflict label Feb 19, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 19, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added the state: conflict PR with conflict label Feb 19, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 19, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Contributor Author

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with current SoO usage in Lab and it works

@gmuloc
Copy link
Contributor Author

gmuloc commented Feb 19, 2024

@ClausHolbechArista for the last commit 7807e3d it feels like we are missing some filtering on static routes (as we would not want the ones coming from WAN to be advertised, but we would want the one coming from tenant)

@ClausHolbechArista ClausHolbechArista merged commit 11cde43 into aristanetworks:devel Feb 20, 2024
38 checks passed
gmuloc added a commit to gmuloc/avd that referenced this pull request Feb 20, 2024
sugetha24 pushed a commit to sugetha24/ansible-avd that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants