Feat(eos_cli_config_gen): Add dot1x protocol bpdu bypass #3622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
|
I am sorry, I messed the end of file new line in |
Comment on lines
12
to
17
| {% if dot1x.protocol_bpdu_bypass is arista.avd.defined(true) %} | ||
| dot1x protocol bpdu bypass | ||
| {% endif %} | ||
| {% if dot1x.protocol_lldp_bypass is arista.avd.defined(true) %} | ||
| dot1x protocol lldp bypass | ||
| {% endif %} |
There was a problem hiding this comment.
Please swap the order of bpdu and lldp. That is how it is rendered on EOS. Thanks.
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/dot1x-2.cfg
Outdated
Show resolved
Hide resolved
…ended/configs/dot1x-2.cfg
ClausHolbechArista
approved these changes
Feb 16, 2024
ClausHolbechArista
added
the
one approval
chetryan
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Starting with EOS 4.31.2F there is a new feature with dotx1x available:
dot1x protocol bpdu bypass
This allows spanning-tree bdpu packets to bypass dot1x that for example bpduguard would work even there is no client authenticated.
Related Issue(s)
Fixes #3621
Component(s) name
arista.avd.eos_cli_config_genProposed changes
How to test
should add globally
Checklist
User Checklist
Repository Checklist