Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Option to define evpn_vlan_bundle for SVIs #3623

Merged
merged 14 commits into from Feb 29, 2024
Merged

Feat(eos_designs): Option to define evpn_vlan_bundle for SVIs #3623

merged 14 commits into from Feb 29, 2024

Conversation

bjmeuer
Copy link
Contributor

@bjmeuer bjmeuer commented Feb 14, 2024

Change Summary

Add the possibilty to define a vlan-aware-bundle name which should be used for one or several SVIs, even if the SVIs are defined in different VRFs.

Related Issue(s)

Fixes #3297

Component(s) name

arista.avd.eos_designs

Proposed changes

Adding the option 'evpn_vlan_bundle' to the 'svis' section. It behaves the same way as it is for 'l2vlans' today.

How to test

tenants:
  - name: SIT
    vlan_aware_bundle_number_base: 300
    mac_vrf_vni_base: 20000
    vrfs:
      - name: SIT_VRF
        vrf_vni: 789654
        svis:
          - id: 1008
            name: SVI_1
            enabled: true
            evpn_vlan_bundle: bundle3
            tags: ['sit']
      - name: SIT2
        vrf_vni: 654789
        svis:
          - id: 1011
            name: SVI_4
            enabled: true
            evpn_vlan_bundle: bundle3
            tags: ['sit']

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@bjmeuer bjmeuer requested review from a team as code owners February 14, 2024 12:16
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Feb 14, 2024
@ClausHolbechArista ClausHolbechArista requested a review from a team February 27, 2024 07:11
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Feb 27, 2024
carl-baillargeon
carl-baillargeon approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit 56f60eb into aristanetworks:devel Feb 29, 2024
38 checks passed
sugetha24 pushed a commit to sugetha24/ansible-avd that referenced this pull request Mar 2, 2024
@bjmeuer @ClausHolbechArista @sugetha24
Feat(eos_designs): Option to define evpn_vlan_bundle for SVIs (arista…
c543223 
…networks#3623)

Co-authored-by: Claus Holbech <holbech@arista.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

Assignees

@bjmeuer bjmeuer

Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
3 participants
@bjmeuer @ClausHolbechArista @carl-baillargeon