Feat(eos_cli_config_gen): Add event-handler trigger on-maintenance.

[Shivani-gslab]

Change Summary

Add event-handler trigger "on-maintenance".

Related Issue(s)

Fixes #2951

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Adding an option for "on-maintenance" in event-handlers.trigger and updated the data-model for the same.

How to test

Add input trigger on-maintenance:

- name: trigger-on-maintenance
    trigger: on-maintenance
    trigger_on_maintenance:
      operation: enter
      interface:
        interface_type: Ethernet
        interface_number: 4
      stage: all
    action_type: bash
    action: echo "on-maintenance"

Check the output config:

!
event-handler trigger-on-maintenance
   trigger on-maintenance enter interface Ethernet 4 all
   action bash echo "on-maintenance"

Test the config on EOS CLI

Checklist

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[MaheshGSLAB]

LGMT, tested on lab

[sugetha24]

LGTM!

[ClausHolbechArista]

.

[kmueller68]

@ClausHolbechArista Thank you very much for implementing this.

[kmueller68]

@ClausHolbechArista

I have tested this addition to the event-handlers but it does not fix my warnings

on-maintenancehas two important flavours:

• on-maintenance enter
• on-maintenance exit

TASK [arista.avd.eos_cli_config_gen : Generate eos intended configuration] *****************************************************************
[WARNING]: [KHM-REWE-DC2-LEAF-01A]: 'Validation Error: event_handlers[14].trigger': 'on-maintenance enter unit System begin' is not one of
['on-boot', 'on-counters', 'on-intf', 'on-logging', 'on-maintenance', 'on-startup-config', 'vm-tracer vm']

event_handlers:
  - name: ON-MAINTENANCE-ENTER
    action_type: bash
    action: "FastCli -p 15 -c downlink-maint; EOF"
    trigger: on-maintenance enter unit System begin
    asynchronous: true

  - name: ON-MAINTENANCE-EXIT
    action_type: bash
    action: "FastCli -p 15 -c downlink-nomaint; EOF"
    trigger: on-maintenance exit unit System begin
    asynchronous: true

[Shivani-gslab]

@ClausHolbechArista

I have tested this addition to the event-handlers but it does not fix my warnings

on-maintenancehas two important flavours:

• on-maintenance enter
• on-maintenance exit

TASK [arista.avd.eos_cli_config_gen : Generate eos intended configuration] *****************************************************************
[WARNING]: [KHM-REWE-DC2-LEAF-01A]: 'Validation Error: event_handlers[14].trigger': 'on-maintenance enter unit System begin' is not one of
['on-boot', 'on-counters', 'on-intf', 'on-logging', 'on-maintenance', 'on-startup-config', 'vm-tracer vm']

event_handlers:
  - name: ON-MAINTENANCE-ENTER
    action_type: bash
    action: "FastCli -p 15 -c downlink-maint; EOF"
    trigger: on-maintenance enter unit System begin
    asynchronous: true

  - name: ON-MAINTENANCE-EXIT
    action_type: bash
    action: "FastCli -p 15 -c downlink-nomaint; EOF"
    trigger: on-maintenance exit unit System begin
    asynchronous: true

Hi @kmueller68,

According to the data-model we have, you need to give the input in below format:

 - name: ON-MAINTENANCE-ENTER
    trigger: on-maintenance
    trigger_on_maintenance:
      operation: enter
      unit: System
      action: begin
    action_type: bash
    action: echo "on-maintenance"

[kmueller68]

Hi @Shivani-gslab
Thank you very much for your super fast repsonse.
I missed the new data model for this.

I have tested it right now with the new model again and it is working well.

Thank you!