Feat(eos_designs): STUN SSL profile support #3636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
state: CI Updated
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
amitsagar-arsita
force-pushed
the
dtls_stun
branch
from
66c7784
to
67bddb0
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
amitsagar-arsita
force-pushed
the
dtls_stun
branch
from
3cd5b8e
to
20c8a5d
Compare
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_shared_utils/wan.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/docs/tables/node-type-structure.md
Outdated
Show resolved
Hide resolved
...llections/arista/avd/roles/eos_designs/schemas/schema_fragments/wan_route_servers.schema.yml
Outdated
Show resolved
Hide resolved
...llections/arista/avd/roles/eos_designs/schemas/schema_fragments/wan_route_servers.schema.yml
Outdated
Show resolved
Hide resolved
gmuloc
changed the title
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
gmuloc
reviewed
Feb 23, 2024
...ions/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/CV_PATHFINDER_TESTS.yml
Outdated
Show resolved
Hide resolved
gmuloc
reviewed
Feb 26, 2024
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_shared_utils/wan.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_shared_utils/wan.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_shared_utils/wan.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_shared_utils/wan.py
Outdated
Show resolved
Hide resolved
...vd/molecule/eos_designs_unit_tests/intended/configs/cv-pathfinder-edge-no-default-policy.cfg
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_shared_utils/wan.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_shared_utils/wan.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/docs/tables/node-type-structure.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/docs/tables/node-type-structure.md
Outdated
Show resolved
Hide resolved
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
amitsagar-arsita
force-pushed
the
dtls_stun
branch
2 times, most recently
from
95df5d9
to
13c1946
Compare
|
Need to add a test case to show multiple ssl profiles for an edge or transit device. |
gmuloc
reviewed
Feb 28, 2024
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_shared_utils/wan.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_shared_utils/wan.py
Outdated
Show resolved
Hide resolved
.../arista/avd/roles/eos_designs/schemas/schema_fragments/wan_stun_dtls_profile_name.schema.yml
Show resolved
Hide resolved
|
Looks good to me overall. |
ClausHolbechArista
force-pushed
the
dtls_stun
branch
from
fdaf48c
to
899a86a
Compare
gmuloc
approved these changes
Feb 29, 2024
sugetha24
pushed a commit
to sugetha24/ansible-avd
that referenced
this pull request
Mar 2, 2024
Co-authored-by: Claus Holbech <holbech@arista.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Support of ssl profile for stun communication.
Related Issue(s)
Fixes #3526
Component(s) name
arista.avd.eos_designsProposed changes
Adding ssl profile element under the wan_rr node type and wan_route_servers.
One needs to provide the ssl_profile under wan_route_servers in the case where the route server is not part of the same inventory.
Ssl profile can be provided to any one of the peer route servers and will be applicable for all in the same inventory.
How to test
Tested using molecule.
Checklist
User Checklist
Repository Checklist