-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): Add support for hop count lowest in load-balancing policies #3646
Merged
carlbuchmann
merged 6 commits into
aristanetworks:devel
from
gmuloc:add-hop-count-lowest-to-eos-designs
Feb 27, 2024
Merged
Feat(eos_designs): Add support for hop count lowest in load-balancing policies #3646
carlbuchmann
merged 6 commits into
aristanetworks:devel
from
gmuloc:add-hop-count-lowest-to-eos-designs
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClausHolbechArista
approved these changes
Feb 21, 2024
...tions/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_virtual_topology.schema.yml
Show resolved
Hide resolved
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…a_fragments/defs_virtual_topology.schema.yml
a241f54
to
2bf41c0
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
...tions/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_virtual_topology.schema.yml
Show resolved
Hide resolved
...s_designs_unit_tests/intended/structured_configs/cv-pathfinder-edge-no-common-path-group.yml
Outdated
Show resolved
Hide resolved
…a_fragments/defs_virtual_topology.schema.yml
carlbuchmann
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can merge once our pre-commit CI bot re-renders the schema and documentation!
sugetha24
pushed a commit
to sugetha24/ansible-avd
that referenced
this pull request
Feb 28, 2024
… policies (aristanetworks#3646) Co-authored-by: Claus Holbech <holbech@arista.com>
gmuloc
added a commit
to gmuloc/avd
that referenced
this pull request
Mar 11, 2024
… policies (aristanetworks#3646) Co-authored-by: Claus Holbech <holbech@arista.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
EPIC - AVD AutoVPN/WAN
one approval
This PR has one approval and is only missing one more.
rn: Feat(eos_designs)
role: eos_designs
issue related to eos_designs role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
cf title
Component(s) name
arista.avd.eos_designs
Proposed changes
Bring in the virtual_topology schema the possibility to configure
lowest_hop_count
that will be used on the LB polciy generated.NOTE: This is not supported for classic AutoVPN as it does not support multi-hop
How to test
molecule
Checklist
TODO: consider a way to enable it on the automatically generated policies (control plane and so on)
Repository Checklist