Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Add support for hop count lowest in load-balancing policies #3646

Merged

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Feb 21, 2024

Change Summary

cf title

Component(s) name

arista.avd.eos_designs

Proposed changes

Bring in the virtual_topology schema the possibility to configure lowest_hop_count that will be used on the LB polciy generated.

NOTE: This is not supported for classic AutoVPN as it does not support multi-hop

How to test

molecule

Checklist

TODO: consider a way to enable it on the automatically generated policies (control plane and so on)

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners February 21, 2024 11:13
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Feb 21, 2024
@ClausHolbechArista ClausHolbechArista requested a review from a team February 21, 2024 14:28
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Feb 21, 2024
@github-actions github-actions bot added the state: conflict PR with conflict label Feb 23, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@gmuloc gmuloc force-pushed the add-hop-count-lowest-to-eos-designs branch from a241f54 to 2bf41c0 Compare February 26, 2024 11:47
@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 26, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

…a_fragments/defs_virtual_topology.schema.yml
@carlbuchmann carlbuchmann self-requested a review February 27, 2024 15:53
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can merge once our pre-commit CI bot re-renders the schema and documentation!

@carlbuchmann carlbuchmann merged commit 97dc640 into aristanetworks:devel Feb 27, 2024
38 checks passed
sugetha24 pushed a commit to sugetha24/ansible-avd that referenced this pull request Feb 28, 2024
… policies (aristanetworks#3646)

Co-authored-by: Claus Holbech <holbech@arista.com>
gmuloc added a commit to gmuloc/avd that referenced this pull request Mar 11, 2024
… policies (aristanetworks#3646)

Co-authored-by: Claus Holbech <holbech@arista.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPIC - AVD AutoVPN/WAN one approval This PR has one approval and is only missing one more. rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants