Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Add 1-step Boundary Clock support #3668

Merged
merged 5 commits into from
Mar 1, 2024
Merged

Feat(eos_designs): Add 1-step Boundary Clock support #3668

merged 5 commits into from
Mar 1, 2024

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Feb 27, 2024 •
edited
Loading

Change Summary

Add 1-step Boundary Clock support to <node_type_keys.key>

Related Issue(s)

Fixes #3030

##Depends on:

Component(s) name

arista.avd.eos_designs

Proposed changes

Adding mode and mode_one_step keys to ptp in node_type_keys.key

<node_type_keys.key>:
      defaults:
        ptp:
          mode: <str; "boundary" | "transparent">
          mode_one_step: <bool; default=False>
      nodes:
        - name: <str; required; unique>
          ptp:
            mode: <str; "boundary" | "transparent">
            mode_one_step: <bool; default=False>

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Feb 27, 2024
@Shivani-gslab Shivani-gslab marked this pull request as ready for review February 28, 2024 07:34
@Shivani-gslab Shivani-gslab requested review from a team as code owners February 28, 2024 07:34
@ClausHolbechArista ClausHolbechArista marked this pull request as draft March 1, 2024 08:30
@Shivani-gslab Shivani-gslab marked this pull request as ready for review March 1, 2024 09:25
@ClausHolbechArista ClausHolbechArista requested a review from a team March 1, 2024 12:10
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Mar 1, 2024
gmuloc
gmuloc approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc merged commit 3cf7293 into aristanetworks:devel Mar 1, 2024
38 checks passed
sugetha24 pushed a commit to sugetha24/ansible-avd that referenced this pull request Mar 2, 2024
@Shivani-gslab @sugetha24
Feat(eos_designs): Add 1-step Boundary Clock support (aristanetworks#…
e50945e 
…3668)
@Shivani-gslab Shivani-gslab deleted the #issue3030 branch April 16, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@Shivani-gslab Shivani-gslab

Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat(eos_designs): 1-step Boundary Clock support
3 participants
@Shivani-gslab @gmuloc @ClausHolbechArista