Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs,eos_cli_config_gen): Add support for MLAG port-channels to endpoints with PTP #3672

Merged
merged 11 commits into from
Apr 30, 2024

Conversation

Vibhu-gslab
Copy link
Contributor

@Vibhu-gslab Vibhu-gslab commented Feb 27, 2024

Change Summary

Add support for connected endpoints running PTP on MLAG switches

Related Issue(s)

Fixes #3627

Component(s) name

arista.avd.eos_designs

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Vibhu-gslab Vibhu-gslab requested review from a team as code owners February 27, 2024 13:51
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Feb 27, 2024
@Vibhu-gslab Vibhu-gslab changed the title Feat(eos_designs):Add support for connected endpoints running PTP on MLAG switches Feat(eos_designs): Add support for connected endpoints running PTP on MLAG switches Feb 27, 2024
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_designs): Add support for connected endpoints running PTP on MLAG switches Feat(eos_designs, eos_cli_config_gen): Add support for connected endpoints running PTP on MLAG switches Feb 28, 2024
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_designs, eos_cli_config_gen): Add support for connected endpoints running PTP on MLAG switches Feat(eos_designs,eos_cli_config_gen): Add support for connected endpoints running PTP on MLAG switches Feb 28, 2024
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_designs,eos_cli_config_gen): Add support for connected endpoints running PTP on MLAG switches Feat(eos_designs,eos_cli_config_gen): Add support for MLAG port-channels to endpoints with PTP Feb 29, 2024
@Vibhu-gslab Vibhu-gslab marked this pull request as draft March 1, 2024 06:24
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review March 1, 2024 06:33
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review March 1, 2024 11:40
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista
Copy link
Contributor

@pvinci-arista please test this PR which should address your request.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Apr 18, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@pvinci-arista
Copy link
Contributor

LGTM

Copy link
Contributor

@pvinci-arista pvinci-arista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit a92b35a into aristanetworks:devel Apr 30, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_designs|eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for connected endpoints running PTP on MLAG switches
4 participants