Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add support for raw eos_cli under router_bgp #3673

Merged
merged 7 commits into from
Apr 5, 2024
Merged

Feat(eos_cli_config_gen): Add support for raw eos_cli under router_bgp #3673

merged 7 commits into from
Apr 5, 2024

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented Feb 28, 2024 •
edited by gmuloc
Loading

Change Summary

Add support for raw cli under BGP address-family-evpn.

Related Issue(s)

Fixes #3570

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Added feature to add raw cli to address-family-evpn in router_bgp.

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated labels Feb 28, 2024
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review February 28, 2024 10:18
ClausHolbechArista
ClausHolbechArista reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the title to be more precise compared to what you are adding here.

...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml Outdated Show resolved Hide resolved
@gmuloc gmuloc changed the title Expand eos_cli support for BGP configuration #3570 Feat(eos_cli_config_gen): Expand eos_cli support for BGP configuration Feb 28, 2024
@laxmikantchintakindi laxmikantchintakindi changed the title Feat(eos_cli_config_gen): Expand eos_cli support for BGP configuration Feat(eos_cli_config_gen):Add support for raw cli under BGP address-family-evpn. Feb 28, 2024
@gmuloc gmuloc changed the title Feat(eos_cli_config_gen):Add support for raw cli under BGP address-family-evpn. Feat(eos_cli_config_gen): Add support for raw cli under BGP address-family-evpn. Feb 28, 2024
@Shivani-gslab
Copy link
Contributor

Shivani-gslab commented Feb 29, 2024 •
edited
Loading

As per the issue description, do we need to add eos_cli under router_bgp.bgp or router_bgpas well ?
@ClausHolbechArista @gmuloc

@ClausHolbechArista
Copy link
Contributor

As per the issue description, do we need to add eos_cli under router_bgp.bgp or router_bgpas well ? @ClausHolbechArista @gmuloc

From the issue I read it as we should just add router_bgp.eos_cli. There is no need to add it specifically under address_family_evpn since that is a static CLI, which can just be included in the CLI the user puts under eos_cli.

@Shivani-gslab Shivani-gslab marked this pull request as draft February 29, 2024 08:49
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review February 29, 2024 13:06
@Shivani-gslab Shivani-gslab marked this pull request as draft March 1, 2024 09:45
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Mar 4, 2024
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review March 4, 2024 07:34
@sugetha24 sugetha24 self-requested a review March 18, 2024 17:39
sugetha24
sugetha24 approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@sugetha24 sugetha24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Tested: Molecule tests with various options under address-family evpn

@gmuloc gmuloc changed the title Feat(eos_cli_config_gen): Add support for raw cli under BGP address-family-evpn. Feat(eos_cli_config_gen): Add support for raw eos_cli under router_bgp Apr 5, 2024
@gmuloc gmuloc merged commit 7407a35 into aristanetworks:devel Apr 5, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista left review comments

@Shivani-gslab Shivani-gslab Shivani-gslab left review comments

@gmuloc gmuloc gmuloc approved these changes

@sugetha24 sugetha24 sugetha24 approved these changes

Assignees

@laxmikantchintakindi laxmikantchintakindi

Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expand eos_cli support for BGP configuration
5 participants
@laxmikantchintakindi @Shivani-gslab @ClausHolbechArista @gmuloc @sugetha24