Feat(eos_cli_config_gen): Add support for setting the ASN notation

[colinmacgiolla]

Change Summary

Add support for selecting ASN Notation

Related Issue(s)

Fixes #1832

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

This adds the following key to the router_bgp dict:
as_notation: <asdot | asplain>

EOS by default is in asplain, and the documentation is updated to include either way (default, or explicitly set)

How to test

Created molecule test case router-bgp-asdot

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[Vibhu-gslab]

LGTM!

[ClausHolbechArista]

Since you are adding a default value in the docs, you get this wide update of every molecule device doc. If you instead had an if arista.avd.defined check before printing it, you could remove almost all the molecule updates.
I am good either way, so will approve.

Notice you will have to update molecule (again and again) every time we merge a PR, until this one is merged.

[colinmacgiolla]

Since you are adding a default value in the docs, you get this wide update of every molecule device doc. If you instead had an if arista.avd.defined check before printing it, you could remove almost all the molecule updates. I am good either way, so will approve.

Notice you will have to update molecule (again and again) every time we merge a PR, until this one is merged.

then lets merge quickly 😜