Feat(eos_designs): Add ability to override wan control plane policy #3690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
state: CI Updated
|
Just found an issue in schema that is somehow related to this PR: Can you change the default value to be |
gmuloc
changed the title
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ayushmittal-arista
force-pushed
the
cpoverride
branch
from
9319ba6
to
ed79dce
Compare
github-actions
bot
added
state: Documentation role Updated
role: eos_designs
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ayushmittal-arista
force-pushed
the
cpoverride
branch
2 times, most recently
from
03a2ac3
to
3a9c347
Compare
gmuloc
requested changes
Mar 7, 2024
...ions/arista/avd/roles/eos_designs/schemas/schema_fragments/wan_virtual_topologies.schema.yml
Show resolved
Hide resolved
...ions/arista/avd/roles/eos_designs/schemas/schema_fragments/wan_virtual_topologies.schema.yml
Outdated
Show resolved
Hide resolved
...ions/arista/avd/roles/eos_designs/schemas/schema_fragments/wan_virtual_topologies.schema.yml
Outdated
Show resolved
Hide resolved
...ions/arista/avd/roles/eos_designs/schemas/schema_fragments/wan_virtual_topologies.schema.yml
Outdated
Show resolved
Hide resolved
...le/eos_designs_unit_tests/inventory/group_vars/cv-pathfinder-custom-control-plane-policy.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_designs_unit_tests/inventory/hosts.yml
Outdated
Show resolved
Hide resolved
ayushmittal-arista
force-pushed
the
cpoverride
branch
from
3a9c347
to
b18ad9b
Compare
github-actions
bot
added
the
role: eos_cli_config_gen
ayushmittal-arista
force-pushed
the
cpoverride
branch
from
b18ad9b
to
a825fcf
Compare
github-actions
bot
removed
the
role: eos_cli_config_gen
gmuloc
approved these changes
Mar 8, 2024
gmuloc
added
the
one approval
|
This one needs a rerun of molecule. |
ansible_collections/arista/avd/roles/eos_designs/python_modules/network_services/utils.py
Outdated
Show resolved
Hide resolved
...ions/arista/avd/roles/eos_designs/schemas/schema_fragments/wan_virtual_topologies.schema.yml
Outdated
Show resolved
Hide resolved
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ayushmittal-arista
force-pushed
the
cpoverride
branch
from
e16626b
to
dd25fd0
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ClausHolbechArista
changed the title
ansible_collections/arista/avd/roles/eos_designs/python_modules/network_services/utils.py
Outdated
Show resolved
Hide resolved
ayushmittal-arista
force-pushed
the
cpoverride
branch
from
597a915
to
7712a1c
Compare
ayushmittal-arista
force-pushed
the
cpoverride
branch
from
7712a1c
to
e5ad745
Compare
ClausHolbechArista
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
We provide user to either configure the control plane policy or we auto generate it. Add a molecule test to test the overriding.
Related Issue(s)
Fixes https://github.com/aristanetworks/avd-internal/issues/143
Component(s) name
arista.avd.eos_designsProposed changes
1.) Override control plane policy test
2.) Introduce application_profile parameter in control_plane_virtual_topology so that we can override APP-PROFILE-CONTROL-PLANE name.
3.) Added optional definition, i.e user can just override the name without defining the profile in application classification in which case we will auto-generate the profile definition ( same as what we are doing now for APP-PROFILE-CONTROL-PLANE)
4.) Alternatively, he also wants to override the application classification as well, he can just define the profile in application classification section
How to test
moleculeChecklist
User Checklist
Fix schema https://github.com/aristanetworks/avd/blob/devel/ansible_collections/arista/avd/roles/eos_designs/schemas/schema_fragments/wan_virtual_topologies.schema.yml#L73
Can you change the default value to be -CONTROL-PLANE in the schema description for name?
Repository Checklist