Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_validate_state): Added support to validate DPS interface state #3692

Merged
merged 8 commits into from Mar 8, 2024
Merged

Feat(eos_validate_state): Added support to validate DPS interface state #3692

merged 8 commits into from Mar 8, 2024

Conversation

MaheshGSLAB
Copy link
Contributor

Change Summary

Added the support to validate DPS interface state

Related Issue(s)

Fixes #3687

Component(s) name

arista.avd.eos_validate_state

Proposed changes

Added dps_interfaces in existing model to test the DPS interface state.

How to test

Run molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review March 4, 2024 07:37
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners March 4, 2024 07:37
@MaheshGSLAB MaheshGSLAB requested a review from gmuloc March 5, 2024 14:33
gmuloc
gmuloc reviewed Mar 6, 2024
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this - the outcome looks better this way with the Dps1 tests only on the WAN routers as would be in a real network. have you tested the generated test against some device maybe on some other setup you have and seen it pass?

@MaheshGSLAB
Copy link
Contributor Author

Thanks for updating this - the outcome looks better this way with the Dps1 tests only on the WAN routers as would be in a real network. have you tested the generated test against some device maybe on some other setup you have and seen it pass?

Yes ran on lab and able to see the test for WAN router also got pass.
Screenshot 2024-03-07 at 19 28 45

gmuloc
gmuloc approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @MaheshGSLAB

carl-baillargeon
carl-baillargeon approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Very nice to have WAN stuff in molecule now. Thanks

@gmuloc gmuloc merged commit 56f1546 into aristanetworks:devel Mar 8, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

Assignees

@MaheshGSLAB MaheshGSLAB

Labels
EPIC - AVD AutoVPN/WAN rn: Feat(eos_validate_state) role: eos_validate_state state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support to validate DPS interface state
3 participants
@MaheshGSLAB @gmuloc @carl-baillargeon