Refactor(eos_validate_state): ANTA Refactor AvdTestBase #3701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaheshGSLAB
approved these changes
Mar 6, 2024
ansible_collections/arista/avd/plugins/plugin_utils/eos_validate_state_utils/avdtestbase.py
Show resolved
Hide resolved
gmuloc
requested changes
Mar 7, 2024
ansible_collections/arista/avd/plugins/plugin_utils/eos_validate_state_utils/config_manager.py
Show resolved
Hide resolved
Comment on lines
89
to
90
| for loopback_interface in loopback_interfaces: | ||
| if loopback_interface.get("name") == "Loopback0": |
There was a problem hiding this comment.
Suggested change
| for loopback_interface in loopback_interfaces: | |
| if loopback_interface.get("name") == "Loopback0": | |
| for loopback_interface in loopback_interfaces: | |
| if (loopback_intefrace := get_item(loopback_interface, "name", "Loopback0") is not None: |
There was a problem hiding this comment.
Right I refactored the function a bit in 554e20b we can't really use continue since we want to check the VTEP loopbacks as well.
...ble_collections/arista/avd/plugins/plugin_utils/eos_validate_state_utils/get_anta_results.py
Show resolved
Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/eos_validate_state_utils/mixins.py
Outdated
Show resolved
Hide resolved
...le_collections/arista/avd/roles/eos_validate_state/python_modules/tests/avdtestinterfaces.py
Outdated
Show resolved
Hide resolved
..._collections/arista/avd/roles/eos_validate_state/python_modules/tests/avdtestconnectivity.py
Outdated
Show resolved
Hide resolved
| log_msg = f"{message}. {log_msg}" if prepend_message else f"{log_msg} {message}." | ||
|
|
||
| # Logging the message | ||
| log_level = logging.getLevelName(log_level.upper()) |
There was a problem hiding this comment.
upper is seless here as it would have failed line 38 already if not upper
There was a problem hiding this comment.
No because I want the function to handle both lower and upper case log_level argument.
ansible_collections/arista/avd/plugins/plugin_utils/eos_validate_state_utils/avdtestbase.py
Outdated
Show resolved
Hide resolved
gmuloc
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Refactor AvdTestBase to improve maintainability, clarity and performance (fixes #3304).
Related Issue(s)
Fixes #3304
Component(s) name
arista.avd.eos_validate_stateANTA modeProposed changes
ConfigManagerclass to manage each device configuration and create required variables for the tests. This class improves performance since it is created per device and not per tests.DeviceUtilsMixinandValidationMixinmixin classes to theAvdTestBaseand move the existing methods to these.logged_getas it was unnecessary and was removing functionality of thegetutil function.How to test
ansible-playbook playbooks/fabric-validate.yml -e use_anta=trueChecklist
User Checklist
Repository Checklist