Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add InfluxDB support #3705

Merged
merged 37 commits into from
May 13, 2024
Merged

Feat(eos_cli_config_gen): Add InfluxDB support #3705

merged 37 commits into from
May 13, 2024

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented Mar 6, 2024 •
edited

Change Summary

Generate the configuration for Telegraf to stream to InfluxDB.

Related Issue(s)

Fixes #2464

Component(s) name

`arista.avd.eos_cli_config_gen

Proposed changes

Added schema file, test file and template for influx db.
Generated influxdb.cfg by executing molecule.

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Mar 6, 2024
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review March 7, 2024 11:23
@laxmikantchintakindi laxmikantchintakindi marked this pull request as draft March 8, 2024 12:37
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review March 12, 2024 10:57
@github-actions github-actions bot added the role: eos_designs issue related to eos_designs role label Apr 18, 2024
sugetha24
sugetha24 previously approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@sugetha24 sugetha24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ClausHolbechArista
ClausHolbechArista requested changes Apr 25, 2024
View reviewed changes
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/influxdb.md Outdated Show resolved Hide resolved
...collections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/influxdb.schema.yml Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/influxdb.j2 Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/influxdb.j2 Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/influxdb.j2 Outdated Show resolved Hide resolved
...collections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/influxdb.schema.yml Outdated Show resolved Hide resolved
...collections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/influxdb.schema.yml Outdated Show resolved Hide resolved
...collections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/influxdb.schema.yml Outdated Show resolved Hide resolved
...collections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/influxdb.schema.yml Outdated Show resolved Hide resolved
...collections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/influxdb.schema.yml Outdated Show resolved Hide resolved
@ClausHolbechArista ClausHolbechArista dismissed sugetha24’s stale review April 25, 2024 08:22

Many changes requires, so please review again once those are in. Please also review the comments to see what we need to catch going forward.

@laxmikantchintakindi laxmikantchintakindi marked this pull request as draft April 25, 2024 15:04
@Shivani-gslab Shivani-gslab marked this pull request as ready for review May 8, 2024 08:16
Shivani-gslab
Shivani-gslab approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shivani-gslab Shivani-gslab marked this pull request as draft May 9, 2024 10:32
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review May 10, 2024 05:33
@Shivani-gslab Shivani-gslab marked this pull request as draft May 10, 2024 07:01
Vibhu-gslab
Vibhu-gslab approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@Vibhu-gslab Vibhu-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review May 10, 2024 09:50
@ClausHolbechArista ClausHolbechArista merged commit b8e7925 into aristanetworks:devel May 13, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@Vibhu-gslab Vibhu-gslab Vibhu-gslab approved these changes

@Shivani-gslab Shivani-gslab Shivani-gslab approved these changes

@sugetha24 sugetha24 sugetha24 left review comments

Assignees

@laxmikantchintakindi laxmikantchintakindi

Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add InfluxDB support
5 participants
@laxmikantchintakindi @ClausHolbechArista @sugetha24 @Vibhu-gslab @Shivani-gslab