Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_cli_config_gen): Comply with EOS tacacs servers configuration order #3711

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

carlbuchmann
Copy link
Member

Change Summary

Comply with EOS tacacs servers configuration order

Related Issue(s)

Fixes #3708

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Remove sorting on for loop tacacs_servers.hosts

How to test

Molecule tests updated, no longer sorting.

@carlbuchmann carlbuchmann requested review from a team as code owners March 6, 2024 17:52
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR labels Mar 6, 2024
Copy link
Contributor

@ayushmittal-arista ayushmittal-arista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If primary_key for list of dicts, is validated, we can also set primary_key for tacacs-server in this PR

@ClausHolbechArista
Copy link
Contributor

If primary_key for list of dicts, is validated, we can also set primary_key for tacacs-server in this PR

We can not in this case. Since there is a VRF field. Primary_key also implies unique values, and here the same host could be set in several VRFs.

@ayushmittal-arista
Copy link
Contributor

If primary_key for list of dicts, is validated, we can also set primary_key for tacacs-server in this PR

We can not in this case. Since there is a VRF field. Primary_key also implies unique values, and here the same host could be set in several VRFs.

I see yes you are right.
Primary Key here is a combination of multiple values. We can't set just use host alone.

@ClausHolbechArista ClausHolbechArista merged commit e299bfb into aristanetworks:devel Mar 7, 2024
77 checks passed
ayushmittal-arista pushed a commit to ayushmittal-arista/ayush-avd that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Fix(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix(eos_cli_config_gen): Comply with EOS tacacs servers configuration order
3 participants