Feat(eos_designs): Add support for directly connected WAN HA #3720

gmuloc · 2024-03-07T17:31:54Z

NOTE blocked by #4107

Change Summary

This PR contains

new model for directly connected HA link
modification of eBGP LAN route-maps
Addition of iBGP session(s) between WAN HA peers using
Routes received from peer are set with Local Preference 50 to still prefer WAN routes

Pros of iBGP EVPN session:

This will support WAN HA in EVERY possible LAN scenario

PLEASE refer to internal documentation

Related Issue(s)

Discussion with CV Pathfinder team

Component(s) name

arista.avd.eos_designs

Proposed changes

cf summary

How to test

molecule + lab

Checklist

User Checklist

Update documentation

To discuss with reviewers

dhcp support for HA link
cross iBGP sessions
-> only one direct link approved

Repository Checklist

My code has been rebased from devel before I start
I have read the CONTRIBUTING document.
My change requires a change to the documentation and documentation have been updated accordingly.
I have updated molecule CI testing accordingly. (check the box if not applicable)

ansible_collections/arista/avd/roles/eos_designs/docs/tables/node-type-wan-configuration.md

...ections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/cv-pathfinder-edge3A.cfg

gmuloc · 2024-03-11T17:15:27Z

..._collections/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_node_type.schema.yml

@@ -1259,6 +1259,33 @@ $defs:
                type: bool
                default: true
                description: Enable / Disable IPsec over HA path-group when HA is enabled.
+              ha_interfaces:


this could using dhcp IP addresses (in cloud in particular) so probably we need to change this model to something along the line of

ha_interfaces: - name: ip_address: < dhcp | IPv4 > peer_ip_address: <need an IP to know where to connect, can be the known one allocated by DHCP>

@ClausHolbechArista for further discussion

disadvantage is no pool - so maybe we need to add ip_address: < dhcp | pool | IPv4 > with default pool

github-actions · 2024-03-18T21:24:53Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2024-03-18T21:32:48Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions · 2024-03-26T12:51:39Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2024-06-03T14:45:40Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_shared_utils/wan.py

...le_collections/arista/avd/roles/eos_designs/docs/tables/management-flow-tracking-settings.md

ansible_collections/arista/avd/roles/eos_designs/python_modules/underlay/route_maps.py

...eos_designs_unit_tests/intended/configs/cv-pathfinder-custom-control-plane-policy-edge-1.cfg

...ections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/cv-pathfinder-edge2A.cfg

ClausHolbechArista · 2024-06-07T11:18:42Z

...ections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/cv-pathfinder-edge2A.cfg

 route-map RM-BGP-UNDERLAY-PEERS-OUT permit 20
+   description Advertise local routes towards LAN
+   match route-type local


we are missing routes learned from an l3_interface or other edge kind of interface with dynamic routing, like a firewall.
Maybe we should set a tag everywhere instead of these route-type matches. It will also be useful for the ospf lan case.

l3_interface learned route can configure an extra route-map entry right? This may not even be a use case today.
For OSPF we can use the same route-map I think

Fixed in 9d5e835

...ections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/cv-pathfinder-edge2A.cfg

github-actions · 2024-06-07T20:45:23Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2024-06-10T13:20:17Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

sonarcloud · 2024-06-10T13:21:04Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

gmuloc · 2024-06-12T07:22:27Z

...eos_designs_unit_tests/intended/configs/cv-pathfinder-custom-control-plane-policy-edge-1.cfg

@@ -215,14 +215,6 @@ route-map RM-BGP-UNDERLAY-PEERS-IN permit 40
   description Mark prefixes originated from the LAN
   set extcommunity soo 192.168.42.1:511 additive
 !
-route-map RM-BGP-UNDERLAY-PEERS-OUT permit 10


breaking change -> we should warn every one we know using this.

gmuloc · 2024-06-12T07:33:33Z

...eos_designs_unit_tests/intended/configs/cv-pathfinder-custom-control-plane-policy-edge-1.cfg

@@ -215,14 +215,6 @@ route-map RM-BGP-UNDERLAY-PEERS-IN permit 40
   description Mark prefixes originated from the LAN
   set extcommunity soo 192.168.42.1:511 additive
 !
-route-map RM-BGP-UNDERLAY-PEERS-OUT permit 10
-   description Advertise local routes towards LAN
-   match extcommunity ECL-EVPN-SOO


add limitation regading route from eBGP peer in VRF default not advertised to the WAN - TODO

gmuloc · 2024-06-12T07:36:48Z

...ections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/cv-pathfinder-edge2A.cfg

-route-map RM-BGP-UNDERLAY-PEERS-OUT permit 40
-   description Advertise WAN HA prefixes towards LAN
-   match ip address prefix-list PL-WAN-HA-PREFIXES
+   description Permit every other valid route


Suggested change

description Permit every other valid route

github-actions · 2024-06-14T12:56:51Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2024-06-17T12:41:04Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions · 2024-06-17T15:12:49Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

gmuloc added the EPIC - AVD AutoVPN/WAN label Mar 7, 2024

github-actions bot assigned gmuloc Mar 7, 2024

github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Mar 7, 2024

gmuloc commented Mar 8, 2024

View reviewed changes

ansible_collections/arista/avd/roles/eos_designs/docs/tables/node-type-wan-configuration.md Outdated Show resolved Hide resolved

gmuloc commented Mar 8, 2024

View reviewed changes

ansible_collections/arista/avd/roles/eos_designs/docs/tables/node-type-wan-configuration.md Outdated Show resolved Hide resolved

gmuloc commented Mar 11, 2024

View reviewed changes

...ections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/cv-pathfinder-edge3A.cfg Outdated Show resolved Hide resolved

gmuloc commented Mar 11, 2024

View reviewed changes

gmuloc force-pushed the directly-connected-ha branch from 9e81600 to eb14328 Compare March 18, 2024 21:22

github-actions bot added the state: conflict PR with conflict label Mar 18, 2024

gmuloc added 2 commits March 18, 2024 21:24

Feat(eos_designs): Add support for directly connected WAN HA

23c0823

Refactor: Address some PR discussion

a5b54b8

gmuloc force-pushed the directly-connected-ha branch from eb14328 to a5b54b8 Compare March 18, 2024 21:32

github-actions bot removed the state: conflict PR with conflict label Mar 18, 2024

gmuloc added 4 commits March 18, 2024 22:34

Refactor: Add iBGP EVPN Gateway for WAN HA

62d0342

Refactor: Test in lab

feadf44

Test: Run molecule

fb8caa9

Merge branch 'devel' into directly-connected-ha

8a78aa9

gmuloc marked this pull request as ready for review March 19, 2024 22:09

gmuloc requested review from a team as code owners March 19, 2024 22:09

gmuloc added 2 commits March 21, 2024 15:09

Refactor: Change the route-maps all over again

c651be6

Refactor: Fix previous commit

7ddd8f1

github-actions bot added the state: conflict PR with conflict label Mar 26, 2024

Merge branch 'devel' into directly-connected-ha

868c6c0

gmuloc marked this pull request as draft April 5, 2024 15:59

Merge branch 'devel' into directly-connected-ha

296f527

github-actions bot removed the state: conflict PR with conflict label Jun 3, 2024

ClausHolbechArista reviewed Jun 4, 2024

View reviewed changes

gmuloc added 3 commits June 6, 2024 09:26

Refactor: Address PR comments

53ee6b9

Merge branch 'devel' into directly-connected-ha

7d89907

Test: Run molecule

21c3a5c

ClausHolbechArista reviewed Jun 7, 2024

View reviewed changes

...eos_designs_unit_tests/intended/configs/cv-pathfinder-custom-control-plane-policy-edge-1.cfg Show resolved Hide resolved

ClausHolbechArista requested changes Jun 7, 2024

View reviewed changes

Refactor: Addres PR comments

04e3c2a

github-actions bot added the state: conflict PR with conflict label Jun 7, 2024

gmuloc added 2 commits June 10, 2024 15:16

Refactor: Change the route-maps again

9d5e835

Merge branch 'devel' into directly-connected-ha

b7016cb

github-actions bot removed the state: conflict PR with conflict label Jun 10, 2024

gmuloc commented Jun 12, 2024

View reviewed changes

gmuloc mentioned this pull request Jun 12, 2024

Fix(eos_designs)!: Remove eBGP LAN outbound route-map for WAN #4107

Merged

4 tasks

carlbuchmann marked this pull request as draft June 14, 2024 12:17

github-actions bot added the state: conflict PR with conflict label Jun 14, 2024

Merge branch 'devel' into directly-connected-ha

bd0ee3a

github-actions bot removed the state: conflict PR with conflict label Jun 17, 2024

CI: Fix codespell

946287c

github-actions bot added the state: conflict PR with conflict label Jun 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat(eos_designs): Add support for directly connected WAN HA #3720

Feat(eos_designs): Add support for directly connected WAN HA #3720

gmuloc commented Mar 7, 2024 •

edited

gmuloc Mar 11, 2024 •

edited

github-actions bot commented Mar 18, 2024

github-actions bot commented Mar 18, 2024

github-actions bot commented Mar 26, 2024

github-actions bot commented Jun 3, 2024

ClausHolbechArista Jun 7, 2024

gmuloc Jun 7, 2024

gmuloc Jun 10, 2024

github-actions bot commented Jun 7, 2024

github-actions bot commented Jun 10, 2024

sonarcloud bot commented Jun 10, 2024

gmuloc Jun 12, 2024

gmuloc Jun 12, 2024

gmuloc Jun 12, 2024

github-actions bot commented Jun 14, 2024

github-actions bot commented Jun 17, 2024

github-actions bot commented Jun 17, 2024

Feat(eos_designs): Add support for directly connected WAN HA #3720

Are you sure you want to change the base?

Feat(eos_designs): Add support for directly connected WAN HA #3720

Conversation

gmuloc commented Mar 7, 2024 • edited

Change Summary

Related Issue(s)

Component(s) name

Proposed changes

How to test

Checklist

User Checklist

To discuss with reviewers

Repository Checklist

gmuloc Mar 11, 2024 • edited

Choose a reason for hiding this comment

github-actions bot commented Mar 18, 2024

github-actions bot commented Mar 18, 2024

github-actions bot commented Mar 26, 2024

github-actions bot commented Jun 3, 2024

ClausHolbechArista Jun 7, 2024

Choose a reason for hiding this comment

gmuloc Jun 7, 2024

Choose a reason for hiding this comment

gmuloc Jun 10, 2024

Choose a reason for hiding this comment

github-actions bot commented Jun 7, 2024

github-actions bot commented Jun 10, 2024

sonarcloud bot commented Jun 10, 2024

Quality Gate passed

gmuloc Jun 12, 2024

Choose a reason for hiding this comment

gmuloc Jun 12, 2024

Choose a reason for hiding this comment

gmuloc Jun 12, 2024

Choose a reason for hiding this comment

github-actions bot commented Jun 14, 2024

github-actions bot commented Jun 17, 2024

github-actions bot commented Jun 17, 2024

gmuloc commented Mar 7, 2024 •

edited

gmuloc Mar 11, 2024 •

edited