Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor(eos_designs): Make DHCP default route generated by default #3724

Merged
merged 2 commits into from Mar 8, 2024
Merged

Refactor(eos_designs): Make DHCP default route generated by default #3724

merged 2 commits into from Mar 8, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Mar 8, 2024

Change Summary

Change default for `dhcp

Component(s) name

arista.avd.eos_designs

Proposed changes

  • change default value in schema

How to test

molecule

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners March 8, 2024 08:41
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Mar 8, 2024
carl-baillargeon
carl-baillargeon approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc merged commit 6c9a5dc into aristanetworks:devel Mar 8, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

@ayushmittal-arista ayushmittal-arista ayushmittal-arista approved these changes

Assignees

@gmuloc gmuloc

Labels
EPIC - AVD AutoVPN/WAN rn: Refactor(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gmuloc @carl-baillargeon @ayushmittal-arista