Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_designs): Use WAN VNI for cv-pathfinder metadata #3728

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Use WAN VNI for cv-pathfinder metadata

Component(s) name

arista.avd.eos_designs

Proposed changes

Set VNI in CV-Pathfinder metadata based on wan_virtual_topologies.vrfs[].wan_vni instead of VNI from network services.

How to test

Existing molecule is reflecting the correct VNI now.

Also tested removing the default VRF from inputs, and it was still getting VNI 1 as it should.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested review from a team as code owners March 9, 2024 11:39
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR role: eos_designs issue related to eos_designs role labels Mar 9, 2024
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in lab environment

@carlbuchmann carlbuchmann requested a review from gmuloc March 9, 2024 21:08
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Mar 11, 2024
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmuloc gmuloc merged commit 0928fde into aristanetworks:devel Mar 11, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Fix(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants