Fix(eos_designs): Do not generate DP IPsec profile when HA ipsec is disabled #3733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
state: CI Updated
ClausHolbechArista
approved these changes
Mar 12, 2024
ClausHolbechArista
added
the
one approval
sugetha24
pushed a commit
to sugetha24/ansible-avd
that referenced
this pull request
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Current code properly does not render the path-selection ipsec config for LAN_HA path-group if
wan_ha.ipsec: Falsebut still generates the IKE policy and add it to the profile.This PR fixes this
Related Issue(s)
Found by systest
Component(s) name
arista.avd.eos_designsProposed changes
cf summary
How to test
molecule
Checklist
Repository Checklist