-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(eos_validate_state): ANTA Fix the report to have consistent test descriptions, categories and input details #3743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansible_collections/arista/avd/plugins/plugin_utils/eos_validate_state_utils/md_report.py
Outdated
Show resolved
Hide resolved
MaheshGSLAB
reviewed
Mar 20, 2024
...ections/arista/avd/molecule/eos_validate_state/intended/test_catalogs/dc1-leaf1a-catalog.yml
Outdated
Show resolved
Hide resolved
...ections/arista/avd/molecule/eos_validate_state/intended/test_catalogs/dc1-leaf1a-catalog.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_validate_state/reports/FABRIC-state.csv
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_validate_state/reports/FABRIC-state.csv
Show resolved
Hide resolved
MaheshGSLAB
reviewed
Mar 22, 2024
ansible_collections/arista/avd/molecule/eos_validate_state/reports/FABRIC-state.csv
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_validate_state/reports/FABRIC-state.csv
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_validate_state/reports/FABRIC-state.csv
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_validate_state/reports/FABRIC-state.csv
Show resolved
Hide resolved
MaheshGSLAB
approved these changes
Mar 22, 2024
ansible_collections/arista/avd/plugins/plugin_utils/eos_validate_state_utils/csv_report.py
Show resolved
Hide resolved
carlbuchmann
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gmuloc
approved these changes
Mar 26, 2024
This was referenced Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
EPIC - eos_validate_state ANTA
one approval
This PR has one approval and is only missing one more.
rn: Fix(eos_validate_state)
role: eos_validate_state
state: CI Updated
CI scenario have been updated in the PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Update the report of validate state to have consistent test descriptions, categories and input. See below for an example.
This new structure will be a lot easier to work with when we will add more tests in the future. It is also consistent if a user provides a custom catalog. The same category will be reported instead of having AVD categories mixed with ANTA categories like
Routing
andRouting Table
.Related Issue(s)
Fixes #3712 #3713 #3714
Component(s) name
arista.avd.eos_validate_state
ANTAProposed changes
We now have the following columns:
ID
--> Test IDDUT
--> Device Under TestCategories
--> Test categories reported from the test engine (ANTA)Test
--> ANTA test nameDescription
--> Description of the test reported from ANTAInputs
--> Inputs and context that AVD generated for the testResult
--> PASS, FAIL, etc.Messages
--> Messages in the result from ANTA. Usually the reason why the test failed.Update to the report:
![image](https://private-user-images.githubusercontent.com/63206086/313046297-0bc9fe96-8b44-4ce9-827a-3fdad133e500.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEzMzAwMDAsIm5iZiI6MTcyMTMyOTcwMCwicGF0aCI6Ii82MzIwNjA4Ni8zMTMwNDYyOTctMGJjOWZlOTYtOGI0NC00Y2U5LTgyN2EtM2ZkYWQxMzNlNTAwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE4VDE5MDgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRiNWQ1NGU3NDc1MzQ4NTNhMjhjNzAxYzRlOTRhZWFkOGI5ZThjY2EwOTdhMjQxOWI4YjVhOTQ2MTg1MWViZmYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.cuIBBSg9bnHunJT-IciPMnvWjEJDnWrC3DayZ-C2PNE)
How to test
ansible-playbook playbooks/fabric-validate.yml -e use_anta=true
Check the report to make sure there are no typos, confusion or missing stuff.
Checklist
User Checklist
Repository Checklist