Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(plugins): Add support for python3.9 for get_all_with_path #3763

Conversation

sugetha24
Copy link
Contributor

@sugetha24 sugetha24 commented Mar 21, 2024

Change Summary

PR #3725 introduced incompatible changes with python 3.9
This PR adds backward compatibility for the same.

@sugetha24 sugetha24 requested review from a team as code owners March 21, 2024 22:18
@sugetha24 sugetha24 changed the title Bug(plugins): Add backwards support for python3.9 Fix(plugins): Add backwards support for python3.9 Mar 21, 2024
@sugetha24 sugetha24 force-pushed the feat/plugins/add-unique_keys-to-schema-python-3.9-support branch from ac42e30 to 259519a Compare March 21, 2024 22:20
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for fixing.

@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Mar 22, 2024
@ClausHolbechArista ClausHolbechArista requested a review from a team March 22, 2024 07:11
@ClausHolbechArista ClausHolbechArista changed the title Fix(plugins): Add backwards support for python3.9 Fix(plugins): Add support for python3.9 for get_all_with_path Mar 22, 2024
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc merged commit 57b85d5 into aristanetworks:devel Mar 22, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Fix(plugins)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants