Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_designs): Set default_underlay_routing_protocol: none for wan_rr and wan_router #3775

Merged

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Mar 26, 2024

Change Summary

The rational behind this change is that most WAN edge sites would be single router with LAN. Having this config will prevent some eBGP config to be generated when not needed (which should also be looked into).

This can still be overwritten of course as done in molecule.

Component(s) name

arista.avd.eos_designs

How to test

molecule

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners March 26, 2024 08:24
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Mar 26, 2024
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Mar 26, 2024
@ClausHolbechArista ClausHolbechArista requested a review from a team March 26, 2024 08:36
@ClausHolbechArista ClausHolbechArista added this to the v4.7.0 milestone Mar 26, 2024
@gmuloc gmuloc merged commit 25fb450 into aristanetworks:devel Mar 26, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPIC - AVD AutoVPN/WAN one approval This PR has one approval and is only missing one more. rn: Refactor(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants