Feat(eos_designs): Add more granular settings for flow_tracking #3776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
state: CI Updated
...ections/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_adapter_config.schema.yml
Outdated
Show resolved
Hide resolved
...ctions/arista/avd/roles/eos_designs/schemas/schema_fragments/fabric_flow_tracking.schema.yml
Outdated
Show resolved
Hide resolved
...ctions/arista/avd/roles/eos_designs/schemas/schema_fragments/fabric_flow_tracking.schema.yml
Outdated
Show resolved
Hide resolved
...ctions/arista/avd/roles/eos_designs/schemas/schema_fragments/fabric_flow_tracking.schema.yml
Outdated
Show resolved
Hide resolved
...ions/arista/avd/roles/eos_designs/schemas/schema_fragments/flow_tracking_settings.schema.yml
Outdated
Show resolved
Hide resolved
gmuloc
requested changes
Mar 26, 2024
...ctions/arista/avd/roles/eos_designs/schemas/schema_fragments/fabric_flow_tracking.schema.yml
Outdated
Show resolved
Hide resolved
...ions/arista/avd/roles/eos_designs/schemas/schema_fragments/flow_tracking_settings.schema.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/underlay/utils.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/underlay/utils.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_shared_utils/flow_tracking.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_shared_utils/flow_tracking.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_shared_utils/flow_tracking.py
Outdated
Show resolved
Hide resolved
..._designs_unit_tests/intended/structured_configs/cv-pathfinder-edge-custom-default-policy.yml
Outdated
Show resolved
Hide resolved
...tions/arista/avd/molecule/eos_designs_unit_tests/intended/configs/uplink_lan_wan_router2.cfg
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/overlay/flow_tracking.py
Outdated
Show resolved
Hide resolved
ayushmittal-arista
force-pushed
the
flow_new2
branch
8 times, most recently
from
1e3ad39
to
dc0a228
Compare
...ions/arista/avd/roles/eos_designs/schemas/schema_fragments/flow_tracking_settings.schema.yml
Outdated
Show resolved
Hide resolved
4 tasks
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ayushmittal-arista
force-pushed
the
flow_new2
branch
2 times, most recently
from
24d5a94
to
3991bb9
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ayushmittal-arista
force-pushed
the
flow_new2
branch
from
3991bb9
to
6be73d0
Compare
ansible_collections/arista/avd/molecule/eos_designs_unit_tests/inventory/hosts.yml
Outdated
Show resolved
Hide resolved
...rista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/FLOW_TRACKING_TESTS_LEAFS.yml
Outdated
Show resolved
Hide resolved
...ns/arista/avd/molecule/eos_designs_unit_tests/intended/configs/flow-tracking-tests-leaf3.cfg
Show resolved
Hide resolved
...rista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/FLOW_TRACKING_TESTS_LEAFS.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_shared_utils/flow_tracking.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_shared_utils/flow_tracking.py
Outdated
Show resolved
Hide resolved
...collections/arista/avd/roles/eos_designs/python_modules/core_interfaces_and_l3_edge/utils.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/mlag/avdstructuredconfig.py
Outdated
Show resolved
Hide resolved
...e_collections/arista/avd/roles/eos_designs/python_modules/network_services/dps_interfaces.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/underlay/utils.py
Outdated
Show resolved
Hide resolved
...collections/arista/avd/roles/eos_designs/schemas/schema_fragments/core_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
gmuloc
reviewed
Apr 4, 2024
...ions/arista/avd/roles/eos_designs/schemas/schema_fragments/flow_tracking_settings.schema.yml
Outdated
Show resolved
Hide resolved
gmuloc
reviewed
Apr 4, 2024
...ctions/arista/avd/roles/eos_designs/schemas/schema_fragments/fabric_flow_tracking.schema.yml
Outdated
Show resolved
Hide resolved
...ctions/arista/avd/roles/eos_designs/schemas/schema_fragments/fabric_flow_tracking.schema.yml
Outdated
Show resolved
Hide resolved
...ctions/arista/avd/roles/eos_designs/schemas/schema_fragments/fabric_flow_tracking.schema.yml
Outdated
Show resolved
Hide resolved
...ons/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_flow_tracking_link.schema.yml
Outdated
Show resolved
Hide resolved
ayushmittal-arista
force-pushed
the
flow_new2
branch
3 times, most recently
from
f8114a2
to
e46c0e3
Compare
gmuloc
reviewed
Apr 17, 2024
...rista/avd/roles/eos_designs/schemas/schema_fragments/defs_node_type_l3_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
gmuloc
reviewed
Apr 17, 2024
ansible_collections/arista/avd/roles/eos_designs/python_modules/flows/avdstructuredconfig.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/flows/avdstructuredconfig.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/flows/avdstructuredconfig.py
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/flows/avdstructuredconfig.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/flows/avdstructuredconfig.py
Show resolved
Hide resolved
...tions/arista/avd/molecule/eos_designs_unit_tests/intended/configs/uplink_lan_wan_router2.cfg
Outdated
Show resolved
Hide resolved
...s/arista/avd/molecule/eos_designs_unit_tests/intended/configs/flow-tracking-tests-spine2.cfg
Outdated
Show resolved
Hide resolved
...s/arista/avd/molecule/eos_designs_unit_tests/intended/configs/flow-tracking-tests-spine2.cfg
Show resolved
Hide resolved
...ta/avd/molecule/eos_designs_unit_tests/inventory/group_vars/FLOW_TRACKING_TESTS_SPINES_2.yml
Outdated
Show resolved
Hide resolved
...eos_designs_unit_tests/intended/configs/cv-pathfinder-custom-control-plane-policy-edge-1.cfg
Outdated
Show resolved
Hide resolved
...eos_designs_unit_tests/intended/configs/cv-pathfinder-custom-control-plane-policy-edge-1.cfg
Outdated
Show resolved
Hide resolved
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ayushmittal-arista
force-pushed
the
flow_new2
branch
from
cbaedb2
to
c8c2a74
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
github-actions
bot
added
the
role: eos_cli_config_gen
…a_fragments/defs_node_type_l3_interfaces.schema.yml
gmuloc
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
LGTM once CI is rebuilt after pre-commit trigger
thanks for this @ayushmittal-arista
lets see if we remove the PREVIEW from the model before we merge @ClausHolbechArista
ClausHolbechArista
approved these changes
Apr 23, 2024
...ections/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_adapter_config.schema.yml
Outdated
Show resolved
Hide resolved
...ections/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_adapter_config.schema.yml
Outdated
Show resolved
Hide resolved
...tions/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_network_services.schema.yml
Outdated
Show resolved
Hide resolved
...rista/avd/roles/eos_designs/schemas/schema_fragments/defs_node_type_l3_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
..._collections/arista/avd/roles/eos_designs/schemas/schema_fragments/node_type_keys.schema.yml
Outdated
Show resolved
Hide resolved
|
Thanks @ayushmittal-arista ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Enable flow_tracking for multiple interface types and follow design conventions of sflow
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_designsProposed changes
Change format for flow_tracking_settings to accept multiple trackers, instead of just override settings.
Add fabric_flow_tracking to add toggle for enabling flow tracking on various link types with an option to specify a tracker if want to override. By default, we will add hardware type named FLOW-TRACKER., with some default settings. To override this you will need to specify full block of settings.
Add flow_tracking option at per interface level which can override enable/ tracker type and name.
How to test
moleculeTODO: Add test after data model is approved.
Checklist
User Checklist
Repository Checklist