-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(eos_cli_config_gen): update logic in monitor_sessions #3823
base: devel
Are you sure you want to change the base?
Fix(eos_cli_config_gen): update logic in monitor_sessions #3823
Conversation
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
db61420
to
70a72a3
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
As discussed on chat with @ClausHolbechArista, this PR could trigger some changes for existing deployment with only source pr destination that will suddenly start to generate config (hence a "breaking change"). I would be in favor of: |
..._collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/monitor-sessions.j2
Outdated
Show resolved
Hide resolved
629171c
to
fb11dc2
Compare
Co-authored-by: Claus Holbech <holbech@arista.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Summary
Monitor-session templates expect both keys monitor_session.sources is arista.avd.defined and monitor_session.destinations to be defined before generating any config but this is not required in EOS, so relaxing this check and requirement.
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Update logic and optimize tests in template.
Update indentation.
Updated eos_designs_unit test case where monitor session is configured without destination, and now we see configuration being generated.
How to test
All Molecule tests should pass!