Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Allow VLAN Aware Bundles even if common evpn_vlan_aware_bundles is false #3827

Conversation

bjmeuer
Copy link
Contributor

@bjmeuer bjmeuer commented Apr 9, 2024

Change Summary

If for a l2vlan or svi in network_services a "evpn_vlan_bundle" is defined the common setting of "evpn_vlan_aware_bundle" is ignored. Meaning even if evpn_vlan_aware_bundle:false a vlan aware bundle will be used for a l2vlan/svi when the "evpn_vlan_bundle" is defined for it.

Related Issue(s)

Fixes #3355

Component(s) name

arista.avd.eos_designs

Proposed changes

check if evpn_vlan_bundle is defined for l2vlan or svi and in case that is, configure it as vlan aware bundle else depend on the common evpn_vlan_aware_bundle setting.

How to test

Moleclue test is provided

evpn_vlan_aware_bundles: false
...
tenants:
  - name: BLS
    vlan_aware_bundle_number_base: 300
    mac_vrf_vni_base: 20000
    l2vlans:
      - id: 10
        name: storage_prod
        tags: ['storageProd']
      - id: 90
        name: vlan90
        tags: ['ipmi']
        evpn_vlan_bundle: bundle3
    vrfs:
      - name: SIT_VRF
        vrf_vni: 789654
        svis:
          - id: 1008
            name: SVI_1
            enabled: true
            evpn_vlan_bundle: bundle3
            tags: ['sit']

evpn_vlan_bundles:
  - name: bundle3
    id: 3
    rt_override: 333
    rd_override: 1.1.1.1:333

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@bjmeuer bjmeuer requested review from a team as code owners April 9, 2024 13:15
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Apr 9, 2024
@ClausHolbechArista
Copy link
Contributor

Please also update the doc for the root evpn bundle key, since it's behavior is now to force evpn vlan bundle for all VLANs. And maybe hint that if they only wish to enable bundles for some vlans they can be set with the new(er) key.

@ClausHolbechArista ClausHolbechArista requested a review from a team April 15, 2024 08:27
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Apr 15, 2024
…a_fragments/evpn_vlan_aware_bundles.schema.yml
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_designs): VLAN Aware Bundle if evpn_vlan_bundle defined even if common evpn_vlan_aware_bundles is false Feat(eos_designs): Allow VLAN Aware Bundles even if common evpn_vlan_aware_bundles is false Apr 24, 2024
@ankudinov ankudinov self-requested a review April 24, 2024 12:51
Copy link
Contributor

@ankudinov ankudinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a POC inventory with bundles. Working well and there is a clear improvement compared to 4.7.1 behavior.
LGTM

@ClausHolbechArista ClausHolbechArista merged commit 0922df1 into aristanetworks:devel Apr 24, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VLAN Based Services are always VLAN Aware Bundles, if evpn_vlan_aware_bundles is true
4 participants