-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): Allow VLAN Aware Bundles even if common evpn_vlan_aware_bundles is false #3827
Feat(eos_designs): Allow VLAN Aware Bundles even if common evpn_vlan_aware_bundles is false #3827
Conversation
…etting evpn_vlan_aware_bundles
…on evpn_vlan_aware_bundles
ansible_collections/arista/avd/roles/eos_designs/python_modules/network_services/router_bgp.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/network_services/router_bgp.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/network_services/router_bgp.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/network_services/router_bgp.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/network_services/router_bgp.py
Outdated
Show resolved
Hide resolved
Please also update the doc for the root evpn bundle key, since it's behavior is now to force evpn vlan bundle for all VLANs. And maybe hint that if they only wish to enable bundles for some vlans they can be set with the new(er) key. |
...ons/arista/avd/roles/eos_designs/schemas/schema_fragments/evpn_vlan_aware_bundles.schema.yml
Outdated
Show resolved
Hide resolved
…a_fragments/evpn_vlan_aware_bundles.schema.yml
...ons/arista/avd/roles/eos_designs/schemas/schema_fragments/evpn_vlan_aware_bundles.schema.yml
Outdated
Show resolved
Hide resolved
...ons/arista/avd/roles/eos_designs/schemas/schema_fragments/evpn_vlan_aware_bundles.schema.yml
Outdated
Show resolved
Hide resolved
...ons/arista/avd/roles/eos_designs/schemas/schema_fragments/evpn_vlan_aware_bundles.schema.yml
Outdated
Show resolved
Hide resolved
..._collections/arista/avd/molecule/eos_validate_state/intended/structured_configs/dc1-wan1.yml
Show resolved
Hide resolved
pre-commit will restart
...ons/arista/avd/roles/eos_designs/schemas/schema_fragments/evpn_vlan_aware_bundles.schema.yml
Outdated
Show resolved
Hide resolved
…a_fragments/evpn_vlan_aware_bundles.schema.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on a POC inventory with bundles. Working well and there is a clear improvement compared to 4.7.1 behavior.
LGTM
Change Summary
If for a l2vlan or svi in network_services a "evpn_vlan_bundle" is defined the common setting of "evpn_vlan_aware_bundle" is ignored. Meaning even if evpn_vlan_aware_bundle:false a vlan aware bundle will be used for a l2vlan/svi when the "evpn_vlan_bundle" is defined for it.
Related Issue(s)
Fixes #3355
Component(s) name
arista.avd.eos_designs
Proposed changes
check if evpn_vlan_bundle is defined for l2vlan or svi and in case that is, configure it as vlan aware bundle else depend on the common evpn_vlan_aware_bundle setting.
How to test
Moleclue test is provided
Checklist
User Checklist
Repository Checklist