Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add IPsec and NAT options to tunnel_interfaces. #3830

Merged
merged 8 commits into from
Apr 10, 2024

Conversation

Vibhu-gslab
Copy link
Contributor

Change Summary

Add ip nat service-profile, tunnel mode and tunnel ipsec profile to tunnel interfaces.

Related Issue(s)

Fixes #3824

Component(s) name

arista.avd.eos_cli_config_gen

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Apr 10, 2024
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review April 10, 2024 10:08
@Vibhu-gslab Vibhu-gslab requested review from a team as code owners April 10, 2024 10:08
@Vibhu-gslab Vibhu-gslab requested a review from gmuloc April 10, 2024 10:15
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on lab.

Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit 91347ee into aristanetworks:devel Apr 10, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): Add IPsec and NAT options to tunnel_interfaces
3 participants