Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Support SA lifetime for IP sec #3875

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Apr 17, 2024

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

edge4B(config-ipsec-sa)#show cli commands | grep lifetime
[no|default] sa lifetime <byteLimit> gigabytes
[no|default] sa lifetime <byteLimit> megabytes
[no|default] sa lifetime <packetLimit> thousand-packets
[no|default] sa lifetime <time> [ hours ]

edge4B(config-ipsec-sa)#sa lifetime ?
  <1-24>       Lifetime in hours ( default )
  <1-4000000>  Packet limit in thousands
  <1-6000>     Byte limit in GB ( 1024 MB )
  <1-6144000>  Byte limit in MB ( 1024 KB )

edge4B(config-ipsec-sa)#sa lifetime 5 ?
  gigabytes         Byte limit in GB ( 1024 MB )
  hours             Lifetime in hours ( default )
  megabytes         Byte limit in MB ( 1024 KB )
  thousand-packets  Packet limit in thousands
  <cr>

Proposed schema

         - name: <str; required; unique>
+          sa_lifetime:
+
+            # Lifetime value for this SA.
+            # Valid range depends on the unit.
+            value: <int>
+            unit: <str; "gigabytes" | "hours" | "megabytes" | "thousand-packets"; default="hours">

How to test

molecule

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners April 17, 2024 10:38
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Apr 17, 2024
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on lab also

@ClausHolbechArista ClausHolbechArista merged commit c695b5e into aristanetworks:devel Apr 17, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPIC - AVD AutoVPN/WAN rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants