-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Enhance event-handlers model to accommodate other triggers with their specificities. #3878
Feat(eos_cli_config_gen): Enhance event-handlers model to accommodate other triggers with their specificities. #3878
Conversation
2e1fb54
to
4e8f41f
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
25c0732
to
366f569
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
366f569
to
d090798
Compare
...tions/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/event_handlers.schema.yml
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/event-handlers.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/event-handlers.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing i noticed that when i do not give action for any trigger then playbook get error on documentation.
TASK [arista.avd.eos_cli_config_gen : Generate device documentation] *********************************************************************
fatal: [leaf1-dc1 -> localhost]: FAILED! => {"msg": "'dict object' has no attribute 'action'. 'dict object' has no attribute 'action'"}
Created a separated issue to fix this. |
…odate other triggers with their specificities
5e7997e
to
55f58a5
Compare
ansible_collections/arista/avd/roles/eos_designs/docs/tables/management-settings.md
Show resolved
Hide resolved
e760d1c
to
5783673
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Summary
Refactor event-handlers model to accommodate other triggers with their specificities
Related Issue(s)
Fixes #3267
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Adding a dict with extra settings per trigger type.
How to test
Checklist
User Checklist
Repository Checklist