-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): Add support for mlag_peer_ipv6_pool #3885
Conversation
...le_collections/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/MLAG_IPV6.yml
Outdated
Show resolved
Hide resolved
..._collections/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_node_type.schema.yml
Outdated
Show resolved
Hide resolved
..._collections/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_node_type.schema.yml
Outdated
Show resolved
Hide resolved
..._collections/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_node_type.schema.yml
Outdated
Show resolved
Hide resolved
..._collections/arista/avd/roles/eos_designs/schemas/schema_fragments/defs_node_type.schema.yml
Outdated
Show resolved
Hide resolved
…a_fragments/defs_node_type.schema.yml Co-authored-by: Claus Holbech <holbech@arista.com>
…a_fragments/defs_node_type.schema.yml Co-authored-by: Claus Holbech <holbech@arista.com>
…a_fragments/defs_node_type.schema.yml Co-authored-by: Claus Holbech <holbech@arista.com>
Switched from public AS number to a private AS number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks! Please make sure someone tests this including on EOS so we know the generated config is valid.
Since you are changing the order of structured config, you also get the "joy" of having to rerun all our molecule tests locally. cd ansible_collections/arista/avd/molecule
make refresh-facts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Summary
This PR adds support for configuring the L2 MLAG peer via IPv6. This is accomplished by adding new input-variables and the supporting infrastructure:
Related Issue(s)
#3715
Component(s) name
arista.avd.eos_designs
arista.avd.eos_cli_config_gen
(Documentation only. No logical changes to component.)Proposed changes
This changes adds the capability to configure the MLAG peer using IPv6. To accomplish this a new input variable has been created that allows the selection of an address family via
mlag_peer_address_family
.In addition to this
mlag_peer_ipv6_pool
has been added to specify the IPv6 pool to use.The default subnet when creating peers has been set to
/64
following the current IPv6 best practices, however this is configurable viaipv6_prefix_length
e.g:How to test
molecules have been created and ran:
molecule converge -s eos_designs_unit_tests -- --limit MLAG_IPV6
This has also been ran in a lab environment running vEOS and CVP. This feature has been built and successful tested against a local AVD enviroment setup in this lab.
Limitations
This has not been tested in the scenario where both the normal MLAG peer and the L3 MLAG peer both use the same SVI and is likely unsupported currently.
This scenario will be tested and resolved in a future PR that adds support for configuring the L3 MLAG peer with IPv6.
Checklist
Repository Checklist