Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(eos_cli_config_gen): Remove requirement for original_ip to be unique under interface IP NAT #3900

Merged
merged 8 commits into from Apr 29, 2024
Merged

Fix(eos_cli_config_gen): Remove requirement for original_ip to be unique under interface IP NAT #3900

merged 8 commits into from Apr 29, 2024

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented Apr 24, 2024 •
edited

Change Summary

original_ip need not be unique in interface_ip_nat_static.

Related Issue(s)

Fixes #3894

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Remove original_ip as primary key from interface_ip_nat_static.

How to test

Add an element in interface_ip_nat_static with same original_ip and different original_ports.

Checklist

User Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Apr 24, 2024
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review April 25, 2024 05:27
@laxmikantchintakindi laxmikantchintakindi changed the title Feat(eos_cli_config_gen): Interface IP NAT Support - origin_ip is not unique. Feat(eos_cli_config_gen): Interface IP NAT Support - original_ip is not unique. Apr 26, 2024
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_cli_config_gen): Interface IP NAT Support - original_ip is not unique. Fix(eos_cli_config_gen): Remove requirement for original_ip to be unique under interface IP NAT Apr 29, 2024
@ClausHolbechArista
Copy link
Contributor

pre-commit.ci autofix

@ClausHolbechArista ClausHolbechArista requested a review from a team April 29, 2024 07:25
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Apr 29, 2024
@gmuloc gmuloc merged commit 82f0136 into aristanetworks:devel Apr 29, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@MaheshGSLAB MaheshGSLAB Awaiting requested review from MaheshGSLAB

Assignees

@laxmikantchintakindi laxmikantchintakindi

Labels
one approval This PR has one approval and is only missing one more. rn: Fix(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): Interface IP NAT Support - origin_ip is not unique
4 participants
@laxmikantchintakindi @ClausHolbechArista @gmuloc @MaheshGSLAB