Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Add optional cv-pathfinder site for pathfinders #3904

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Apr 25, 2024

Change Summary

Add optional cv-pathfinder site for pathfinders

Component(s) name

arista.avd.eos_designs

Proposed changes

# Define sites that are outside of the CV Pathfinder hierarchy.
# This is used to arrange pathfinders in the CloudVision topology layout.
cv_pathfinder_global_sites:     <------- NEW

  # The site name.
  - name: <str; required; unique>
    description: <str>

    # Location as a string is resolved on Cloudvision.
    location: <str>

<node-type-key>:
  defaults:
    # The CV Pathfinder region name.
    # This key is required for WAN routers but optional for pathfinders.
    # The region name must be defined under 'cv_pathfinder_regions'.
    cv_pathfinder_region: <str>

    # The CV Pathfinder site name.
    # This key is required for WAN routers but optional for pathfinders.
    # For WAN routers and pathfinders with `cv_pathfinder_region`, the site name must be defined for the relevant region under 'cv_pathfinder_regions'.
    # For pathfinders without `cv_pathfinder_region` set, the site must be defined under `cv_pathfinder_global_sites`.
    cv_pathfinder_site: <str>     <------- MODIFIED BEHAVIOR (SEE DESCRIPTION)

How to test

Updated molecule to have all combinations of region, region+site, site

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested review from a team as code owners April 25, 2024 06:30
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Apr 25, 2024
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Apr 29, 2024
@gmuloc gmuloc merged commit 4909236 into aristanetworks:devel Apr 29, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPIC - AVD AutoVPN/WAN one approval This PR has one approval and is only missing one more. rn: Feat(eos_designs) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants