Feat(eos_designs): Extend the functionality of the is_deployed flag to shutdown BGP peerings. #3916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o shutdown BGP peerings.
github-actions
bot
added
state: CI Updated
laxmikantchintakindi
force-pushed
the
isdeployed
branch
from
df16108
to
83c131e
Compare
laxmikantchintakindi
force-pushed
the
isdeployed
branch
from
83c131e
to
f8836ac
Compare
ansible_collections/arista/avd/roles/eos_designs/python_modules/underlay/router_bgp.py
Outdated
Show resolved
Hide resolved
for more information, see https://pre-commit.ci
.../roles/eos_designs/schemas/schema_fragments/shutdown_bgp_towards_undeployed_peers.schema.yml
Outdated
Show resolved
Hide resolved
…a_fragments/shutdown_bgp_towards_undeployed_peers.schema.yml Co-authored-by: Shivani-gslab <145646625+Shivani-gslab@users.noreply.github.com>
.../roles/eos_designs/schemas/schema_fragments/shutdown_bgp_towards_undeployed_peers.schema.yml
Show resolved
Hide resolved
.../roles/eos_designs/schemas/schema_fragments/shutdown_bgp_towards_undeployed_peers.schema.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/underlay/router_bgp.py
Show resolved
Hide resolved
MaheshGSLAB
reviewed
May 9, 2024
...e_collections/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/DC1_FABRIC.yml
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/python_modules/overlay/router_bgp.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Having BGP peers in a state other than active, causes monitoring issues, and breaks CVP tests. If hosts are intentionally not deployed, then the BGP peerings should be shutdown.
Related Issue(s)
Fixes #3604
Component(s) name
arista.avd.eos_designsProposed changes
Add dict element shutdown: true to neighbors if peer_is_deployed is false.
How to test
Set is_deployed to false for router and check the bgp configuration on the peers.
Checklist
User Checklist
Repository Checklist