-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(eos_cli_config_gen): Fix the schema and template for action in event-handler. #4007
Merged
ClausHolbechArista
merged 7 commits into
aristanetworks:devel
from
Shivani-gslab:event_handler_action
May 21, 2024
Merged
Fix(eos_cli_config_gen): Fix the schema and template for action in event-handler. #4007
ClausHolbechArista
merged 7 commits into
aristanetworks:devel
from
Shivani-gslab:event_handler_action
May 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4007
# Activate the virtual environment
source test-avd-pr-4007/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@event_handler_action#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,event_handler_action --force
# Optional: Install AVD examples
cd test-avd-pr-4007
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
role: eos_designs
issue related to eos_designs role
labels
May 16, 2024
Shivani-gslab
force-pushed
the
event_handler_action
branch
6 times, most recently
from
May 20, 2024 07:01
e17db25
to
f823b60
Compare
Shivani-gslab
force-pushed
the
event_handler_action
branch
from
May 20, 2024 07:02
f823b60
to
ac1f078
Compare
Shivani-gslab
force-pushed
the
event_handler_action
branch
from
May 20, 2024 12:36
c25d996
to
b5d2730
Compare
Vibhu-gslab
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ClausHolbechArista
requested changes
May 21, 2024
...le_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/event-handlers.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/event-handlers.j2
Outdated
Show resolved
Hide resolved
ClausHolbechArista
approved these changes
May 21, 2024
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/event-handlers.j2
Outdated
Show resolved
Hide resolved
…tes/eos/event-handlers.j2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rn: Fix(eos_cli_config_gen)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
role: eos_designs
issue related to eos_designs role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fix the schema and template for action in event-handler
Related Issue(s)
Fixes #3899
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Currently,
action_type
key has three valid_valuesbash
,log
andincrement
but the combination of 2 keys can be implemented in config.Deprecating the existing
action_type
andaction
key and adding new key -Also the current template logic for
action_type
generates wrong config ifaction_type
islog
orincrement
, so fixing it.How to test
Check the config in CLI.
Checklist
User Checklist
Repository Checklist