Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add option for dot1x aaa accounting update interval x seconds. #4017

Merged
merged 2 commits into from
May 21, 2024

Conversation

Vibhu-gslab
Copy link
Contributor

Change Summary

Add option for dot1x aaa accounting update interval seconds.

Related Issue(s)

Fixes #3943

Component(s) name

arista.avd.eos_cli_config_gen

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Vibhu-gslab Vibhu-gslab self-assigned this May 20, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4017
# Activate the virtual environment
source test-avd-pr-4017/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@aaa_3943#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,aaa_3943 --force
# Optional: Install AVD examples
cd test-avd-pr-4017
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels May 20, 2024
@Shivani-gslab Shivani-gslab marked this pull request as ready for review May 20, 2024 12:18
@Shivani-gslab Shivani-gslab requested review from a team as code owners May 20, 2024 12:18
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ClausHolbechArista ClausHolbechArista merged commit 785c1b0 into aristanetworks:devel May 21, 2024
43 checks passed
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_cli_config_gen): Add option for dot1x aaa accounting update interval <x> seconds. Feat(eos_cli_config_gen): Add option for dot1x aaa accounting update interval x seconds. May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature(eos_cli_config_gen): Add option for dot1x aaa accounting update interval <x> seconds
3 participants