Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add Regex pattern for region/zone/site name for router_adapative_virtual_topology #4026

Merged
merged 2 commits into from
May 22, 2024

Conversation

ayushmittal-arista
Copy link
Contributor

Change Summary

Add pattern '^[A-Za-z0-9_.:{}\[\]-]+$' for the region/zone/site name fields.

Related Issue(s)

Fixes #4001

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

How to test

manual

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4026
# Activate the virtual environment
source test-avd-pr-4026/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ayushmittal-arista/ayush-avd.git@addregex#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ayushmittal-arista/ayush-avd.git#/ansible_collections/arista/avd/,addregex --force
# Optional: Install AVD examples
cd test-avd-pr-4026
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated role: eos_designs issue related to eos_designs role labels May 22, 2024
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ClausHolbechArista ClausHolbechArista requested a review from a team May 22, 2024 09:06
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label May 22, 2024
@gmuloc gmuloc merged commit 6fa030a into aristanetworks:devel May 22, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPIC - AVD AutoVPN/WAN one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: Documentation role Updated
Projects
None yet
3 participants