cram: add documentation for the -p option #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snaipe
reviewed
Jan 18, 2022
test/cram.sh
Outdated
| -p/--patch If there is a difference between the expeted output and the | ||
| actual output, the expected output in the file will be patched | ||
| by the actual output. Setting the environment variable | ||
| '$ENV_CRAM_PATCH' has the same effect. The environment variable |
There was a problem hiding this comment.
CRAM_PATCH=1 already does this; I'd just document it as is.
There was a problem hiding this comment.
Ah I am an idot! I re-invented the wheel in a convoluted manner. Fixed.
There was a problem hiding this comment.
btw while we are here, I was telling Ken how good your awk skiils are! but for idiots like me, could you please add some comments on the parsing logic so that I can follow?
There was a problem hiding this comment.
Hey, don't sell yourself short 🙂 My awk skills aren't too impressive, I know awk wizards out there and I'm not yet at that level.
I'll add some comments to explain some of the magic.
Document the '-p'/'--patch' option in the help string. Signed-off-by: Ani Sinha <ani@anisinha.ca>
ani-sinha
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the '-p'/'--patch' option in the help string.
Signed-off-by: Ani Sinha ani@anisinha.ca