Explicitly close files after upload.

aristanetworks · Jan 8, 2024 · a6e86a8 · a6e86a8
1 parent 910c138
commit a6e86a8
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/client/devpi/upload.py b/client/devpi/upload.py
@@ -157,10 +157,15 @@ def post(self, action, path, meta):
         if self.args.dryrun:
             hub.line("skipped: %s" % msg)
         else:
-            r = hub.http.post(self.pypisubmit, dic, files=files,
-                              headers=headers,
-                              auth=hub.current.get_basic_auth(self.pypisubmit),
-                              cert=hub.current.get_client_cert(self.pypisubmit))
+            try:
+                r = hub.http.post(self.pypisubmit, dic, files=files,
+                                  headers=headers,
+                                  auth=hub.current.get_basic_auth(self.pypisubmit),
+                                  cert=hub.current.get_client_cert(self.pypisubmit))
+            finally:
+                if files:
+                    for p, f in files.values():
+                        f.close()
             hub._last_http_stati.append(r.status_code)
             r = HTTPReply(r)
             if r.status_code == 200: