Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry: porting the ocprometheus article from EOSC #79

Merged
merged 4 commits into from
Aug 4, 2021
Merged

Conversation

noredistribution
Copy link
Contributor

closes #8

Copy link
Contributor

@sulrich sulrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • need to resolve the references to the images so that these load when rendered by mkdocs. (e.g.: resources/Grafana1.png.
  • there were some linter snags
  • might be useful to rebase to pick up the changes from main and reduce some of the lining noise from old commits.

Comment on lines 44 to 52
# my global config

global:

scrape_interval: 15s # Set the scrape interval to every 15 seconds. Default is every 1 minute.

evaluation_interval: 15s # Evaluate rules every 15 seconds. The default is every 1 minute.

# scrape_timeout is set to the global default (10s).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, but is there a need to have this double spaced?

Comment on lines 56 to 66
# Alertmanager configuration

alerting:

alertmanagers:

- static_configs:

- targets:

# - alertmanager:9093
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we're not actually using alertmanager should we remove this?


Checking on the GUI, it will give you the following results

![prom13.png](./res/prom13.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

none of the images load for me when i run mkdocs serve

Copy link
Contributor

@sulrich sulrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sulrich sulrich merged commit 55c3035 into main Aug 4, 2021
@sulrich sulrich deleted the ocprometheus branch January 25, 2022 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert EOSC Prometheus article to md
2 participants