Placing two editor controls in the customizer leads to odd behavior. #140

briancwelch · 2015-03-29T17:21:57Z

When placing two editor controls within the customizer, one of the editor controls will have two toolbars.

Code used:

    $controls[] = array(
        'type'        => 'editor',
        'setting'     => 'projects_html_before',
        'label'       => __( 'Add/Edit Projects - Custom HTML (Before)', 'maera-diy' ),
        'description' => __( 'You can use this field to enter any custom HTML that you would like to be displayed before the Add/Edit projects fields in the popup window.', 'maera-diy' ),
        'default'     => '<h1>My Projects</h1>',
        'priority'    => 2,
        'section'     => 'maera_diy_general',
    );

    $controls[] = array(
        'type'        => 'editor',
        'setting'     => 'projects_html_after',
        'label'       => __( 'Add/Edit Projects - Custom HTML (After)', 'maera-diy' ),
        'description' => __( 'You can use this field to enter any custom HTML that you would like to be displayed after the Add/Edit projects fields in the popup window.', 'maera-diy' ),
        'default'     => '<h1>My Projects</h1>',
        'priority'    => 3,
        'section'     => 'maera_diy_general',
    );

Visual Reference.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

The text was updated successfully, but these errors were encountered:

dmgawel · 2015-04-03T12:46:10Z

Which version of WordPress does it affect?

aristath · 2015-04-03T12:46:31Z

latest + trunk.

nickkuijpers · 2015-12-07T23:43:22Z

Any temp fixes for this issue?

aristath · 2015-12-07T23:47:06Z

I'm afraid not... The reason this issue occurs is still a mystery to me, I haven't been able to determine why it occurs.
If we find out why it happens we'll be able to fix it...

nickkuijpers · 2015-12-07T23:53:04Z

Okay, will dive into it. Thanks!

nickkuijpers · 2015-12-08T01:40:54Z

Couldn't find it either.. debugged some scripts and found out the following. If you console.log the registered MCE you see that if you add 1 editor field all goes well but if you add a second one, it loops thought all the registered ones, so first one = 1 time, second time = 3 times. 1 + 2 = 3.

See the following code, this is when i console.log public/wp-includes/class-wp-editor.php at row 1246 add the following so you can view all registered mce's.

console.log(init);

For some reason it double registeres them.

var init, id, $wrap;

            if ( typeof tinymce !== 'undefined' ) {
                for ( id in tinyMCEPreInit.mceInit ) {
                    init = tinyMCEPreInit.mceInit[id];
                    $wrap = tinymce.$( '#wp-' + id + '-wrap' );

                    console.log(init);

                    if ( ( $wrap.hasClass( 'tmce-active' ) || ! tinyMCEPreInit.qtInit.hasOwnProperty( id ) ) && ! init.wp_skip_init ) {
                        tinymce.init( init );

                        if ( ! window.wpActiveEditor ) {
                            window.wpActiveEditor = id;
                        }
                    }
                }
            }

bject {
    theme: "modern",
    skin: "lightgray",
    language: "nl",
    formats: Object,
    relative_urls: false…
}
body_class: "footer_tekst_1 locale-nl-nl"
browser_spellcheck: truecache_suffix: "wp-mce-4205-20150910"
content_css: "http://talento.sageinku/wp-includes/css/dashicons.min.css?ver=4.3.1,http://talento.sageinku/wp-includes/js/tinymce/skins/wordpress/wp-content.css?ver=4.3.1,http://talento.sageinku/wp-content/themes/talento/dist/styles/main.css,http://talento.sageinku/wp-content/plugins/shortcode-ui/css/shortcode-ui-editor-styles.css"
convert_urls: falseend_container_on_empty_block: trueentities: "38,amp,60,lt,62,gt"
entity_encoding: "raw"
fix_list_elements: trueformats: Objectindent: falsekeep_styles: falselanguage: "nl"
menubar: falseplugins: "colorpicker,lists,fullscreen,image,wordpress,wpeditimage,wplink"
preview_styles: "font-family font-size font-weight font-style text-decoration text-transform"
relative_urls: falseremove_script_host: falseresize: "vertical"
selector: "#footer_tekst_1"
skin: "lightgray"
tabfocus_elements: ":prev,:next"
theme: "modern"
toolbar1: "bold,italic,underline,blockquote,strikethrough,bullist,numlist,alignleft,aligncenter,alignright,undo,redo,link,unlink,fullscreen"
toolbar2: ""
toolbar3: ""
toolbar4: ""
wpautop: truewpeditimage_disable_captions: falsewpeditimage_html5_captions: true__proto__: Object
VM38661: 10 Object {
    theme: "modern",
    skin: "lightgray",
    language: "nl",
    formats: Object,
    relative_urls: false…
}
body_class: "footer_tekst_1 locale-nl-nl"
browser_spellcheck: truecache_suffix: "wp-mce-4205-20150910"
content_css: "http://talento.sageinku/wp-includes/css/dashicons.min.css?ver=4.3.1,http://talento.sageinku/wp-includes/js/tinymce/skins/wordpress/wp-content.css?ver=4.3.1,http://talento.sageinku/wp-content/themes/talento/dist/styles/main.css,http://talento.sageinku/wp-content/plugins/shortcode-ui/css/shortcode-ui-editor-styles.css"
convert_urls: falseend_container_on_empty_block: trueentities: "38,amp,60,lt,62,gt"
entity_encoding: "raw"
fix_list_elements: trueformats: Objectindent: falsekeep_styles: falselanguage: "nl"
menubar: falseplugins: "colorpicker,lists,fullscreen,image,wordpress,wpeditimage,wplink"
preview_styles: "font-family font-size font-weight font-style text-decoration text-transform"
relative_urls: falseremove_script_host: falseresize: "vertical"
selector: "#footer_tekst_1"
skin: "lightgray"
tabfocus_elements: ":prev,:next"
theme: "modern"
toolbar1: "bold,italic,underline,blockquote,strikethrough,bullist,numlist,alignleft,aligncenter,alignright,undo,redo,link,unlink,fullscreen"
toolbar2: ""
toolbar3: ""
toolbar4: ""
wpautop: truewpeditimage_disable_captions: falsewpeditimage_html5_captions: true__proto__: Object
VM38661: 10 Object {
    theme: "modern",
    skin: "lightgray",
    language: "nl",
    formats: Object,
    relative_urls: false…
}
body_class: "footer_tekst_2 locale-nl-nl"
browser_spellcheck: truecache_suffix: "wp-mce-4205-20150910"
content_css: "http://talento.sageinku/wp-includes/css/dashicons.min.css?ver=4.3.1,http://talento.sageinku/wp-includes/js/tinymce/skins/wordpress/wp-content.css?ver=4.3.1,http://talento.sageinku/wp-content/themes/talento/dist/styles/main.css,http://talento.sageinku/wp-content/plugins/shortcode-ui/css/shortcode-ui-editor-styles.css"
convert_urls: falseend_container_on_empty_block: trueentities: "38,amp,60,lt,62,gt"
entity_encoding: "raw"
fix_list_elements: trueformats: Objectindent: falsekeep_styles: falselanguage: "nl"
menubar: falseplugins: "colorpicker,lists,fullscreen,image,wordpress,wpeditimage,wplink"
preview_styles: "font-family font-size font-weight font-style text-decoration text-transform"
relative_urls: falseremove_script_host: falseresize: "vertical"
selector: "#footer_tekst_2"
skin: "lightgray"
tabfocus_elements: ":prev,:next"
theme: "modern"
toolbar1: "bold,italic,underline,blockquote,strikethrough,bullist,numlist,alignleft,aligncenter,alignright,undo,redo,link,unlink,fullscreen"
toolbar2: ""
toolbar3: ""
toolbar4: ""
wpautop: truewpeditimage_disable_captions: falsewpeditimage_html5_captions: true__proto__: Object

enginne · 2016-03-16T14:45:15Z

@aristath - I don´t know if this helps to this issue but i found someone who apparently find out what is causing the issue with more than one editor in the customizer.
Apparently they found the cause but they're still struggling with the fix.
I wish i could help but this is way too advanced for my current skills.
Please take a look in:
[https://github.com/paulund/wordpress-theme-customizer-custom-controls/issues/20]

alexdonh · 2016-05-13T10:31:17Z

is this one really resolved? i'm currently on latest rev and looks like it still happening (to me). Anyone else confirm?

code snippets:

Kirki::add_field( 'bushwicked', array( 'type' => 'editor', 'settings' => 'portfolios_content', 'label' => __( 'Content', 'bushwicked' ), 'description' => __( 'Some introductory text content displayed right below the heading.', 'bushwicked' ), 'section' => 'portfolios', 'required' => array( array( 'setting' => 'enable_portfolios', 'operator' => '==', 'value' => 1 ) ) ) );

then

Kirki::add_field( 'bushwicked', array( 'type' => 'editor', 'settings' => 'services_content', 'label' => __( 'Content', 'bushwicked' ), 'description' => __( 'Some introductory text content displayed right below the heading.', 'bushwicked' ), 'section' => 'services', 'required' => array( array( 'setting' => 'enable_services', 'operator' => '==', 'value' => 1 ) ) ) );

(in another section)

manandharsudin · 2016-05-23T09:32:16Z

Yeah, it still exists and not solved when used in theme. But it is working when using Kirki as a plugin.
Hi, @aristath can you take a look.

Thanks

aristath · 2016-05-23T22:53:52Z

Do you perhaps have another plugin activated that uses a WYSIWYG? perhaps something like customize-posts?

manandharsudin · 2016-05-24T04:34:18Z

No, I don't. I've checked it in clean install without any plugin activated.

aristath · 2016-05-24T17:47:10Z

@manandharsudin I believe this was just fixed in the develop branch, can you please verify it?

manandharsudin · 2016-05-25T05:32:26Z

@aristath Yes the develop branch is working fine. Thanks

aristath modified the milestone: 1.0 Mar 29, 2015

aristath added bug help wanted labels Mar 29, 2015

aristath self-assigned this Jun 13, 2015

aristath modified the milestones: 1.1, 1.0 Jun 20, 2015

aristath removed their assignment Sep 19, 2015

aristath added the priority: low label Oct 10, 2015

aristath modified the milestones: 1.1, 2.0 Nov 24, 2015

aristath modified the milestones: 2.0, 2.1 Dec 19, 2015

aristath modified the milestones: 2.2, 2.2.1 Mar 3, 2016

aristath removed this from the 2.2.1 milestone Mar 17, 2016

aristath closed this as completed in a23c824 Apr 27, 2016

aristath mentioned this issue Apr 27, 2016

Problem with new link popup in WYSIWYG Editor #922

Closed

aristath reopened this May 23, 2016

aristath closed this as completed in bc92258 May 24, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Placing two editor controls in the customizer leads to odd behavior. #140

Placing two editor controls in the customizer leads to odd behavior. #140

briancwelch commented Mar 29, 2015

dmgawel commented Apr 3, 2015

aristath commented Apr 3, 2015

nickkuijpers commented Dec 7, 2015

aristath commented Dec 7, 2015

nickkuijpers commented Dec 7, 2015

nickkuijpers commented Dec 8, 2015

enginne commented Mar 16, 2016

alexdonh commented May 13, 2016 •

edited

Loading

manandharsudin commented May 23, 2016 •

edited

Loading

aristath commented May 23, 2016

manandharsudin commented May 24, 2016

aristath commented May 24, 2016

manandharsudin commented May 25, 2016

Placing two editor controls in the customizer leads to odd behavior. #140

Placing two editor controls in the customizer leads to odd behavior. #140

Comments

briancwelch commented Mar 29, 2015

dmgawel commented Apr 3, 2015

aristath commented Apr 3, 2015

nickkuijpers commented Dec 7, 2015

aristath commented Dec 7, 2015

nickkuijpers commented Dec 7, 2015

nickkuijpers commented Dec 8, 2015

enginne commented Mar 16, 2016

alexdonh commented May 13, 2016 • edited Loading

manandharsudin commented May 23, 2016 • edited Loading

aristath commented May 23, 2016

manandharsudin commented May 24, 2016

aristath commented May 24, 2016

manandharsudin commented May 25, 2016

alexdonh commented May 13, 2016 •

edited

Loading

manandharsudin commented May 23, 2016 •

edited

Loading