-
Notifications
You must be signed in to change notification settings - Fork 107
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Correctly process the return status of PutObject and DeleteObject.
Previously the AWS S3 response was ignored. Now we check if the response was successful or not.
- Loading branch information
Showing
2 changed files
with
6 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,7 @@ import Aws.S3.Info | |
import Aws.S3.Metadata | ||
import Aws.S3.Model | ||
import Aws.S3.Query | ||
import Aws.S3.Response | ||
import Aws.Signature | ||
import Aws.Transaction | ||
import Control.Applicative | ||
|
@@ -65,7 +66,8 @@ instance SignQuery PutObject where | |
|
||
instance ResponseConsumer PutObject PutObjectResponse where | ||
type ResponseMetadata PutObjectResponse = S3Metadata | ||
responseConsumer _ _ _ _ _ = do return $ PutObjectResponse Nothing | ||
responseConsumer _ = s3ResponseConsumer $ \_ _ _ -> | ||
return $ PutObjectResponse Nothing | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
aristidb
Owner
|
||
|
||
instance Transaction PutObject PutObjectResponse | ||
|
Shouldn't we parse the object version from the response instead of just blindly returning
Nothing
?