Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Vim keys already included? #15

Closed
jweckman opened this issue Sep 21, 2021 · 6 comments
Closed

[REQUEST] Vim keys already included? #15

jweckman opened this issue Sep 21, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@jweckman
Copy link

I know you already added hjkl navigation to bpytop. Is it missing or am i just too stupid to find out how to configure?

As an idea you may be able to get away with less requests like these if users could add their keybindings to the config file. Not sure how much time would go into implementing that but just a suggestion.

Have to say that i really like this version. As much as i love python this kind of thing is better written in a lower level language.

@jweckman jweckman added the enhancement New feature or request label Sep 21, 2021
@aristocratos
Copy link
Owner

@jweckman
I can't really say that I see much point in having "vim keys" in a program where you're not going to be switching between typing text and moving around especially often.

I could possibly add the keybinds for h j k l in upper-case, that way you can toggle them with caps-lock. But I won't remove the already set default keybindings to accommodate a very small minority of users. You would also still have to use the arrow keys to move the cursor when editing text fields.

Adding support for user customizable keybinds is no small task and isn't gonna be a high priority request right now at least.

@jweckman
Copy link
Author

jweckman commented Oct 2, 2021

Thanks for the reply. I was mainly wondering about the h j k l support :)

The reason why many of us are so annoying related to this detail is that it has become a core component of how we use our computers. It's not simply vim, its basically everything. Bash, zsh, tmux, less, psql, and even web browsers support the home row based navigation standard, which allows us to almost completely not use the arrow keys or the mouse for the most part. Introducing one of the core applications (yours is one of them) with arrow keys breaks the flow so badly that the slowness of bpytop becomes a significantly smaller issue.

What i'm saying is that perhaps some of your biggest fans that are really into performance optimization are now missing out on this rewrite that you spent so much time on, with no clear reason since the support was already there in the earlier version.

Personally, i would recommend against caps-lock based support, since many keyboard driven users remap their escape key to caps-lock since it is used a lot more often.

Again, thank you so much for your work. I will be fine using bpytop but i wanted you to know that this feature would mean a lot to a lot of people and that it is significant enough that maybe someone who knows C would be happy to add full keyboard customization for you. I'm more of a Python/Rust guy so i could not help you at the moment at least.

@itaranto
Copy link

@jweckman I can't really say that I see much point in having "vim keys" in a program where you're not going to be switching between typing text and moving around especially often.

I could possibly add the keybinds for h j k l in upper-case, that way you can toggle them with caps-lock. But I won't remove the already set default keybindings to accommodate a very small minority of users. You would also still have to use the arrow keys to move the cursor when editing text fields.

Adding support for user customizable keybinds is no small task and isn't gonna be a high priority request right now at least.

It may be a minority, yes. But I think there's a considerably amount of Vim users specially power-users that rely heavily on terminal-based applications.

@aristocratos
Copy link
Owner

@jweckman @itaranto
A toggle in the options for enabling Vim keys added in v1.0.15

@itaranto
Copy link

@jweckman @itaranto A toggle in the options for enabling Vim keys added in v1.0.15

Thanks!

@jweckman
Copy link
Author

jweckman commented Feb 6, 2022

@aristocratos Holy cow that was fast. I only realized that you added it now because Brodie Robertson covered your application on youtube. Instantly had to install on my daily driver and reconfigure all my personal ansible scripts. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants