Vectorfield refactors #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sichao25
reviewed
Mar 6, 2023
get_vf_class typo
Sichao25
reviewed
Mar 8, 2023
Sichao25
reviewed
Mar 8, 2023
|
Hi @MukundhMurthy, I am going to make some changes to the issues I mentioned above. Let me know if you don't like those changes. |
|
@Sichao25 Those changes all make sense, thank you for catching them! |
|
This pull request looks good to me. |
Ukyeon
approved these changes
Mar 10, 2023
Xiaojieqiu
reviewed
Mar 10, 2023
|
@Sichao25 please fix my above review comments |
|
@Xiaojieqiu They are done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated docstring to correct format and ensured typing/docstring are added to all user relevant functions