Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fano #474

Merged
merged 34 commits into from May 4, 2023
Merged

Fano #474

merged 34 commits into from May 4, 2023

Conversation

Ukyeon
Copy link
Contributor

@Ukyeon Ukyeon commented Apr 5, 2023 •
edited

The key modifications are

  1. Added the Fano algorithm
  2. The name SVR has been changed to cv_dispersion for avoiding confusion, because now Fano also uses SVR function.
  3. Refactoring in terms of gene selection procedure in preprocessor.
  4. Fix Gini function to run much faster by allowing element-wise vector multiplying operation.

Xiaojieqiu
Xiaojieqiu reviewed Apr 7, 2023
View reviewed changes
dynamo/preprocessing/gene_selection.py Outdated Show resolved Hide resolved
dynamo/preprocessing/gene_selection.py Outdated Show resolved Hide resolved
@Ukyeon Ukyeon mentioned this pull request Apr 18, 2023
Closed
Xiaojieqiu
Xiaojieqiu reviewed Apr 20, 2023
View reviewed changes
dynamo/preprocessing/Preprocessor.py Outdated Show resolved Hide resolved
dynamo/preprocessing/Preprocessor.py Outdated Show resolved Hide resolved
dynamo/preprocessing/Preprocessor.py Outdated Show resolved Hide resolved
dynamo/preprocessing/Preprocessor.py Outdated Show resolved Hide resolved
dynamo/preprocessing/Preprocessor.py Outdated Show resolved Hide resolved
dynamo/preprocessing/gene_selection.py Outdated Show resolved Hide resolved
dynamo/preprocessing/gene_selection.py Outdated Show resolved Hide resolved
dynamo/preprocessing/gene_selection.py Outdated Show resolved Hide resolved
dynamo/preprocessing/gene_selection.py Outdated Show resolved Hide resolved
dynamo/preprocessing/gene_selection.py Outdated Show resolved Hide resolved
Xiaojieqiu
Xiaojieqiu reviewed Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@Xiaojieqiu Xiaojieqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my reviewed code. Please make sure you understand what you are doing when you try to update the code. I don't think the code you changed at several places make sense.

dynamo/preprocessing/gene_selection.py Show resolved Hide resolved
dynamo/preprocessing/gene_selection.py Outdated Show resolved Hide resolved
dynamo/preprocessing/utils.py Outdated Show resolved Hide resolved
dynamo/preprocessing/preprocessor_utils.py Outdated Show resolved Hide resolved
dynamo/preprocessing/preprocessor_utils.py Outdated Show resolved Hide resolved
Sichao25
Sichao25 reviewed Apr 24, 2023
View reviewed changes
dynamo/dynamo_logger.py Outdated Show resolved Hide resolved
@Xiaojieqiu Xiaojieqiu merged commit 9a079f5 into aristoteleo:master May 4, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xiaojieqiu Xiaojieqiu Xiaojieqiu left review comments

@Sichao25 Sichao25 Sichao25 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ukyeon @Xiaojieqiu @Sichao25 @LoveLennone