Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unexpected parameter #496

Merged
merged 1 commit into from May 15, 2023
Merged

Conversation

Sichao25
Copy link
Collaborator

@Sichao25 Sichao25 commented May 9, 2023

Removed an unexpected parameter in the gseapy.

@Xiaojieqiu
Copy link
Collaborator

can you please also update the requirements for gseapy version?

@Sichao25
Copy link
Collaborator Author

Sichao25 commented May 9, 2023

can you please also update the requirements for gseapy version?

gseapy seems to be one extra requirement package. We import it with the following code:

try:   
        import gseapy as gp
except ImportError:
        raise ImportError("You need to install the package gseapy." "install gseapy via pip install gseapy")

Is it better to just update the error message? Or we can add gseapy to the requirements.txt.

@Xiaojieqiu
Copy link
Collaborator

add this to the error message. we should keep the requirements.txt as minimal as possible

@Xiaojieqiu Xiaojieqiu merged commit 6e0e4c2 into aristoteleo:master May 15, 2023
6 checks passed
@Sichao25 Sichao25 deleted the gseapy branch June 1, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants