Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Reorganize pp #500

Merged
merged 9 commits into from May 15, 2023
Merged

Update Reorganize pp #500

merged 9 commits into from May 15, 2023

Conversation

Sichao25
Copy link
Collaborator

@Sichao25 Sichao25 commented May 10, 2023 •
edited

Fixed a few issues in reorganizing preprocessing:

  • add _legacy to every deprecated function.
  • remove extra __init__ file in the root folder.
  • add support for normalize_cell_expr_by_size_factors .
  • solve a few bugs and wrong import statements related to preprocessing.

@Sichao25 Sichao25 requested a review from Ukyeon May 11, 2023 18:01
Ukyeon
Ukyeon reviewed May 11, 2023
View reviewed changes
Copy link
Contributor

@Ukyeon Ukyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Ukyeon Ukyeon marked this pull request as ready for review May 11, 2023 19:21
@Xiaojieqiu
Copy link
Collaborator

looks great

@Xiaojieqiu Xiaojieqiu merged commit b47f151 into aristoteleo:master May 15, 2023
6 checks passed
@Xiaojieqiu Xiaojieqiu mentioned this pull request May 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ukyeon Ukyeon Ukyeon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sichao25 @Xiaojieqiu @Ukyeon